haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a minor compil warning and a Coverity warning

This commit is contained in:
jean-pierre charras 2020-07-30 10:40:51 +02:00
parent b3f638caaf
commit 265f28afe1
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libs/kimath/src/geometry/shape_compound.cpp
View File

@ -52,6 +52,8 @@ SHAPE_COMPOUND::SHAPE_COMPOUND( const SHAPE_COMPOUND& aOther )
{ {
for ( auto shape : aOther.Shapes() ) for ( auto shape : aOther.Shapes() )
m_shapes.push_back( shape->Clone() ); m_shapes.push_back( shape->Clone() );
m_dirty = true;
} }
@ -95,6 +97,7 @@ void SHAPE_COMPOUND::Move ( const VECTOR2I& aVector )
int SHAPE_COMPOUND::Distance( const SEG& aSeg ) const int SHAPE_COMPOUND::Distance( const SEG& aSeg ) const
{ {
assert(false); assert(false);
return 0; // Make compiler happy
} }

7
utils/kicad2step/pcb/oce_utils.cpp
View File

@ -898,7 +898,12 @@ bool PCBMODEL::WriteSTEP( const wxString& aFileName )
if( success ) if( success )
{ {
wxRenameFile( tmpfname, fn.GetFullName(), true ); if( !wxRenameFile( tmpfname, fn.GetFullName(), true ) )
{
ReportMessage( wxString::Format( "Cannot rename temporary file '%s' to '%s'\n",
tmpfname, fn.GetFullName() ) );
success = false;
}
} }
wxSetWorkingDirectory( currCWD ); wxSetWorkingDirectory( currCWD );