haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

teardrops: fix a not very good shape for not round targets after code change.

This commit is contained in:
jean-pierre charras 2022-02-02 13:25:59 +01:00
parent 9260431fe4
commit 27c25debea
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pcbnew/teardrop/teardrop_utils.cpp
View File

@ -352,7 +352,10 @@ void TEARDROP_MANAGER::computeCurvedForRectShape( TEARDROP_PARAMETERS* aCurrPar
int sign = std::abs( angle1 ) >= ANGLE_90 ? 1 : -1; int sign = std::abs( angle1 ) >= ANGLE_90 ? 1 : -1;
VECTOR2I bias( 0, sign * delta_effective ); VECTOR2I bias( 0, sign * delta_effective );
RotatePoint( bias, -angle1 ); // Does not works well with the current algo, due to an initial bug.
// but I (JPC) keep it here because probably it will gives a better shape
// if the algo is refined.
// RotatePoint( bias, angle1 );
ctrl1.x += bias.x; ctrl1.x += bias.x;
ctrl1.y += bias.y; ctrl1.y += bias.y;
@ -380,7 +383,8 @@ void TEARDROP_MANAGER::computeCurvedForRectShape( TEARDROP_PARAMETERS* aCurrPar
bias = VECTOR2I( 0, sign * delta_effective ); bias = VECTOR2I( 0, sign * delta_effective );
RotatePoint( bias, -angle2 ); // Does not works well with the current algo
// RotatePoint( bias, angle2 );
ctrl1.x += bias.x; ctrl1.x += bias.x;
ctrl1.y += bias.y; ctrl1.y += bias.y;