haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Always show pin dangling symbols in Symbol Editor. 

Fixes https://gitlab.com/kicad/code/kicad/issues/8493
This commit is contained in:
Jeff Young 2021-05-27 17:49:53 +01:00
parent 42eae27551
commit 2817c3b3de
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
eeschema/sch_painter.cpp
View File

@ -761,6 +761,11 @@ void SCH_PAINTER::draw( LIB_PIN *aPin, int aLayer )
return; return;
bool drawingShadows = aLayer == LAYER_SELECTION_SHADOWS; bool drawingShadows = aLayer == LAYER_SELECTION_SHADOWS;
#if 1
bool dangling = !m_schematic || aPin->HasFlag(IS_DANGLING );
#else
bool dangling = aPin->HasFlag( IS_DANGLING );
#endif
if( drawingShadows && !aPin->IsSelected() ) if( drawingShadows && !aPin->IsSelected() )
return; return;
@ -776,7 +781,7 @@ void SCH_PAINTER::draw( LIB_PIN *aPin, int aLayer )
} }
else else
{ {
if( aPin->HasFlag( IS_DANGLING ) && aPin->IsPowerConnection() ) if( dangling && aPin->IsPowerConnection() )
drawPinDanglingSymbol( pos, drawingShadows ); drawPinDanglingSymbol( pos, drawingShadows );
return; return;
@ -940,15 +945,18 @@ void SCH_PAINTER::draw( LIB_PIN *aPin, int aLayer )
} }
if( aPin->HasFlag( IS_DANGLING ) && ( aPin->IsVisible() || aPin->IsPowerConnection() ) ) if( dangling )
drawPinDanglingSymbol( pos, drawingShadows ); drawPinDanglingSymbol( pos, drawingShadows );
LIB_PART* libEntry = aPin->GetParent(); LIB_PART* libEntry = aPin->GetParent();
// Draw the labels // Draw the labels
if( drawingShadows && ( libEntry->Type() == LIB_PART_T || libEntry->IsSelected() ) if( drawingShadows
&& ( libEntry->Type() == LIB_PART_T || libEntry->IsSelected() )
&& !eeconfig()->m_Selection.draw_selected_children ) && !eeconfig()->m_Selection.draw_selected_children )
{
return; return;
}
int textOffset = libEntry->GetPinNameOffset(); int textOffset = libEntry->GetPinNameOffset();
@ -1008,7 +1016,7 @@ void SCH_PAINTER::draw( LIB_PIN *aPin, int aLayer )
} }
int insideOffset = textOffset; int insideOffset = textOffset;
int outsideOffset = 10; int outsideOffset = 2 * Mils2iu( PIN_TEXT_MARGIN ) + ( dangling ? TARGET_PIN_RADIUS / 2 : 0 );
float lineThickness = (float) m_schSettings.GetDefaultPenWidth(); float lineThickness = (float) m_schSettings.GetDefaultPenWidth();
float aboveOffset = Mils2iu( PIN_TEXT_MARGIN ) + ( thickness[ABOVE] + lineThickness ) / 2.0; float aboveOffset = Mils2iu( PIN_TEXT_MARGIN ) + ( thickness[ABOVE] + lineThickness ) / 2.0;
float belowOffset = Mils2iu( PIN_TEXT_MARGIN ) + ( thickness[BELOW] + lineThickness ) / 2.0; float belowOffset = Mils2iu( PIN_TEXT_MARGIN ) + ( thickness[BELOW] + lineThickness ) / 2.0;