haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Schematic: don't allow setting footprint for power symbols 

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16505
This commit is contained in:
Mike Williams 2024-01-03 08:51:24 -05:00
parent 1e71899611
commit 2a04e6ac63
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
eeschema/fields_grid_table.cpp
View File

@ -431,8 +431,18 @@ wxGridCellAttr* FIELDS_GRID_TABLE<T>::GetAttr( int aRow, int aCol, wxGridCellAtt
} }
else if( m_parentType == SCH_SYMBOL_T && aRow == FOOTPRINT_FIELD ) else if( m_parentType == SCH_SYMBOL_T && aRow == FOOTPRINT_FIELD )
{ {
m_footprintAttr->IncRef(); // Power symbols have do not appear in the board, so don't allow
return m_footprintAttr; // a footprint
if( m_part->IsPower() )
{
m_readOnlyAttr->IncRef();
return m_readOnlyAttr;
}
else
{
m_footprintAttr->IncRef();
return m_footprintAttr;
}
} }
else if( m_parentType == SCH_SYMBOL_T && aRow == DATASHEET_FIELD ) else if( m_parentType == SCH_SYMBOL_T && aRow == DATASHEET_FIELD )
{ {
@ -868,7 +878,8 @@ template class FIELDS_GRID_TABLE<LIB_FIELD>;
void FIELDS_GRID_TRICKS::showPopupMenu( wxMenu& menu, wxGridEvent& aEvent ) void FIELDS_GRID_TRICKS::showPopupMenu( wxMenu& menu, wxGridEvent& aEvent )
{ {
if( m_grid->GetGridCursorRow() == FOOTPRINT_FIELD && m_grid->GetGridCursorCol() == FDC_VALUE ) if( m_grid->GetGridCursorRow() == FOOTPRINT_FIELD && m_grid->GetGridCursorCol() == FDC_VALUE
&& !m_grid->IsReadOnly( FOOTPRINT_FIELD, FDC_VALUE ) )
{ {
menu.Append( MYID_SELECT_FOOTPRINT, _( "Select Footprint..." ), menu.Append( MYID_SELECT_FOOTPRINT, _( "Select Footprint..." ),
_( "Browse for footprint" ) ); _( "Browse for footprint" ) );