haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't do any hole clearance testing within a single footprint. 

Fixes https://gitlab.com/kicad/code/kicad/issues/8141
This commit is contained in:
Jeff Young 2021-04-11 16:01:34 +01:00
parent 7ba110bd77
commit 2cde76a191
3 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pcbnew/drc/drc_test_provider_copper_clearance.cpp
View File

@ -509,9 +509,8 @@ bool DRC_TEST_PROVIDER_COPPER_CLEARANCE::testPadAgainstItem( PAD* pad, SHAPE* pa
if( fp->IsNetTie() && ( other->Type() == PCB_FP_SHAPE_T || other->Type() == PCB_PAD_T ) )
testClearance = false;
// CADSTAR implements thermal vias using pads insteads of vias
if( fp->AllowThermalPads() && other->Type() == PCB_PAD_T )
testHoles = false;
// No hole testing within a footprint
testHoles = false;
}
if( pad->GetAttribute() == PAD_ATTRIB_NPTH && !pad->FlashLayer( layer ) )

6
pcbnew/footprint.h
View File

@ -241,12 +241,6 @@ public:
return GetKeywords().StartsWith( wxT( "net tie" ) );
}
// Might as well keep all the hacks in the same place....
bool AllowThermalPads() const
{
return GetKeywords().StartsWith( wxT( "allow thermal pads" ) );
}
void Move( const wxPoint& aMoveVector ) override;
void Rotate( const wxPoint& aRotCentre, double aAngle ) override;

1
pcbnew/plugins/cadstar/cadstar_pcb_archive_loader.cpp
View File

@ -655,7 +655,6 @@ void CADSTAR_PCB_ARCHIVE_LOADER::loadComponentLibrary()
wxT( "" ) );
FOOTPRINT* footprint = new FOOTPRINT( m_board );
footprint->SetPosition( getKiCadPoint( component.Origin ) );
footprint->SetKeywords( wxT( "allow thermal pads" ) );
LIB_ID libID;
libID.Parse( fpName, true );