BOM Generation: Unifying reference concatenation using more pythonic string join to avoid trailing comma.

This commit is contained in:
Christian Weickhmann 2023-11-22 10:12:30 +01:00 committed by Jon Evans
parent fd91f8933e
commit 2ee75b1aec
3 changed files with 17 additions and 15 deletions

View File

@ -125,15 +125,16 @@ item = 0
for group in grouped:
del row[:]
refs = ""
refs_l = []
# Add the reference of every component in the group and keep a reference
# to the component so that the other data can be filled in once per group
for component in group:
if len(refs) > 0:
refs += ", "
refs += component.getRef()
refs_l.append( component.getRef() )
c = component
refs = ", ".join(refs_l)
# Fill in the component groups common data
# columns = ['Item', 'Qty', 'Reference(s)', 'Value', 'LibPart', 'Footprint', 'Datasheet', 'DNP'] + sorted(list(columnset))
item += 1
@ -155,4 +156,4 @@ for group in grouped:
f.close()
if not canOpenFile:
sys.exit(1)
sys.exit(1)

View File

@ -60,15 +60,16 @@ grouped = net.groupComponents()
# Output all of the component information
for group in grouped:
refs = ""
refs_l = []
# Add the reference of every component in the group and keep a reference
# to the component so that the other data can be filled in once per group
for component in group:
if refs != "":
refs += ", "
refs += fromNetlistText( component.getRef() )
refs_l.append( fromNetlistText( component.getRef() ) )
c = component
refs = ", ".join(refs_l)
# Fill in the component groups common data
out.writerow([refs, len(group),
fromNetlistText( c.getValue() ),
@ -79,4 +80,4 @@ for group in grouped:
c.getDNPString()])
if not canOpenFile:
sys.exit(1)
sys.exit(1)

View File

@ -94,16 +94,16 @@ grouped = net.groupComponents()
index = 1
for group in grouped:
refs = ""
refs_l = []
# Add the reference of every component in the group and keep a reference
# to the component so that the other data can be filled in once per group
for component in group:
refs += component.getRef() + ", "
refs_l.append( component.getRef() )
c = component
# Remove trailing comma
refs = refs[:-2]
refs = ", ".join(refs_l)
# Fill in the component groups common data
row = []
row.append( index )