haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleanup error handling in VRML export (from coverity scan)

This commit is contained in:
Ian McInerney 2020-01-12 17:18:08 +00:00
parent 00e58cd974
commit 3346f812a9
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
pcbnew/dialogs/dialog_export_vrml.cpp
View File

@ -28,12 +28,12 @@
*/ */
#include <wx/dir.h> #include <wx/dir.h>
#include <fctsys.h>
#include <pcb_edit_frame.h>
#include <kiface_i.h>
#include <pcbnew.h>
#include <class_board.h> #include <class_board.h>
#include <confirm.h>
#include <fctsys.h>
#include <kiface_i.h>
#include <pcb_edit_frame.h>
#include <pcbnew.h>
/* the dialog to create VRML files, derived from DIALOG_EXPORT_3DFILE_BASE, /* the dialog to create VRML files, derived from DIALOG_EXPORT_3DFILE_BASE,
@ -239,15 +239,20 @@ void PCB_EDIT_FRAME::OnExportVRML( wxCommandEvent& event )
if( export3DFiles && !modelPath.DirExists() ) if( export3DFiles && !modelPath.DirExists() )
{ {
modelPath.Mkdir(); if( !modelPath.Mkdir() )
{
wxString msg = wxString::Format(
_( "Unable to create directory \"%s\"" ), modelPath.GetPath() );
DisplayErrorMessage( this, msg );
return;
}
} }
if( !ExportVRML_File( path, scale, export3DFiles, useRelativePaths, if( !ExportVRML_File( path, scale, export3DFiles, useRelativePaths,
usePlainPCB, modelPath.GetPath(), aXRef, aYRef ) ) usePlainPCB, modelPath.GetPath(), aXRef, aYRef ) )
{ {
wxString msg; wxString msg = wxString::Format( _( "Unable to create file \"%s\"" ), path );
msg.Printf( _( "Unable to create file \"%s\"" ), path ); DisplayErrorMessage( this, msg );
wxMessageBox( msg );
return; return;
} }
} }