Add GetLibraryTimestamp to other plugins.

Fixes: lp:1752719
* https://bugs.launchpad.net/kicad/+bug/1752719

pcbnew/eagle_plugin.h

@@ -98,6 +98,11 @@ public:
     MODULE* FootprintLoad( const wxString& aLibraryPath, const wxString& aFootprintName,
             const PROPERTIES* aProperties = NULL ) override;
 
+    long long GetLibraryTimestamp() const override
+    {
+        return getModificationTime( m_lib_path ).GetValue().GetValue();
+    }
+
     bool IsFootprintLibWritable( const wxString& aLibraryPath ) override
     {
         return false;   // until someone writes others like FootprintSave(), etc.

pcbnew/gpcb_plugin.cpp

@@ -280,7 +280,7 @@ GPCB_FPL_CACHE::GPCB_FPL_CACHE( GPCB_PLUGIN* aOwner, const wxString& aLibraryPat
 wxDateTime GPCB_FPL_CACHE::GetLibModificationTime() const
 {
     if( !m_lib_path.DirExists() )
-        return wxDateTime::Now();
+        return wxDateTime( 0.0 );
 
     return m_lib_path.GetModificationTime();
 }
@@ -1131,6 +1131,16 @@ bool GPCB_PLUGIN::FootprintLibDelete( const wxString& aLibraryPath, const PROPER
 }
 
 
+long long GPCB_PLUGIN::GetLibraryTimestamp() const
+{
+    // If we have no cache, return a number which won't match any stored timestamps
+    if( !m_cache )
+        return wxDateTime::Now().GetValue().GetValue();
+
+    return m_cache->GetLibModificationTime().GetValue().GetValue();
+}
+
+
 bool GPCB_PLUGIN::IsFootprintLibWritable( const wxString& aLibraryPath )
 {
     LOCALE_IO   toggle;

pcbnew/gpcb_plugin.h

@@ -74,6 +74,8 @@ public:
     bool FootprintLibDelete( const wxString& aLibraryPath,
                              const PROPERTIES* aProperties = NULL ) override;
 
+    long long GetLibraryTimestamp() const override;
+
     bool IsFootprintLibWritable( const wxString& aLibraryPath ) override;
 
     //-----</PLUGIN API>--------------------------------------------------------

pcbnew/io_mgr.h

@@ -358,11 +358,7 @@ public:
      * directory).
      * Timestamps should not be considered ordered; they either match or they don't.
      */
-    virtual long long GetLibraryTimestamp() const
+    virtual long long GetLibraryTimestamp() const = 0;
-    {
-        // Default implementation.
-        return 0;
-    }
 
     /**
      * Function PrefetchLib

pcbnew/kicad_plugin.cpp

@@ -122,9 +122,10 @@ class FP_CACHE
     wxFileName      m_lib_path;     /// The path of the library.
     MODULE_MAP      m_modules;      /// Map of footprint file name per MODULE*.
 
-    bool            m_cache_dirty;      // Stored separately because it's expensive
+    bool            m_cache_dirty;      // Stored separately because it's expensive to check
-                                        // to check m_cache_timestamp against file.
+                                        // m_cache_timestamp against all the files.
-    long long       m_cache_timestamp;  // A timestamp for the footprint file.
+    long long       m_cache_timestamp;  // A hash of the timestamps for all the footprint
+                                        // files.
 
 public:
     FP_CACHE( PCB_IO* aOwner, const wxString& aLibraryPath );
@@ -2131,7 +2132,7 @@ void PCB_IO::FootprintDelete( const wxString& aLibraryPath, const wxString& aFoo
 
 long long PCB_IO::GetLibraryTimestamp() const
 {
-    // If we have not cache, return a number which won't match any stored timestamps
+    // If we have no cache, return a number which won't match any stored timestamps
     if( !m_cache )
         return wxDateTime::Now().GetValue().GetValue();
 

pcbnew/legacy_plugin.cpp

@@ -3383,6 +3383,16 @@ void LP_CACHE::LoadModules( LINE_READER* aReader )
 }
 
 
+long long LEGACY_PLUGIN::GetLibraryTimestamp() const
+{
+    // If we have no cache, return a number which won't match any stored timestamps
+    if( !m_cache )
+        return wxDateTime::Now().GetValue().GetValue();
+
+    return m_cache->GetLibModificationTime().GetValue().GetValue();
+}
+
+
 void LEGACY_PLUGIN::cacheLib( const wxString& aLibraryPath )
 {
     if( !m_cache || m_cache->m_lib_path != aLibraryPath ||

pcbnew/legacy_plugin.h

@@ -69,7 +69,7 @@ class LEGACY_PLUGIN : public PLUGIN
 
 public:
 
-    //-----<PLUGIN IMPLEMENTATION>----------------------------------------------
+    //-----<PLUGIN API>---------------------------------------------------------
 
     const wxString PluginName() const override
     {
@@ -93,9 +93,11 @@ public:
     bool FootprintLibDelete( const wxString& aLibraryPath,
                              const PROPERTIES* aProperties = NULL ) override;
 
+    long long GetLibraryTimestamp() const override;
+
     bool IsFootprintLibWritable( const wxString& aLibraryPath ) override;
 
-    //-----</PLUGIN IMPLEMENTATION>---------------------------------------------
+    //-----</PLUGIN API>--------------------------------------------------------
 
     typedef int     BIU;
 

pcbnew/pcad2kicadpcb_plugin/pcad_plugin.h

@@ -47,6 +47,12 @@ public:
 
     const wxString  GetFileExtension() const override;
 
+    long long GetLibraryTimestamp() const override
+    {
+        // No support for libraries....
+        return 0;
+    }
+
     // -----</PUBLIC PLUGIN API>-------------------------------------------------
 
     PCAD_PLUGIN();