haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Better error messages (and make an empty pad an error, not a warning).

This commit is contained in:
Jeff Young 2022-10-09 20:24:07 +01:00
parent e866dfe137
commit 35a14b8e5d
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pcbnew/dialogs/dialog_pad_properties.cpp
View File

@ -1256,12 +1256,12 @@ bool DIALOG_PAD_PROPERTIES::padValuesOK()
else if( m_dummyPad->GetShape() == PAD_SHAPE::CIRCLE ) else if( m_dummyPad->GetShape() == PAD_SHAPE::CIRCLE )
{ {
if( pad_size.x <= 0 ) if( pad_size.x <= 0 )
warning_msgs.Add( _( "Warning: Pad size is less than zero." ) ); error_msgs.Add( _( "Error: Pad must have a positive size." ) );
} }
else else
{ {
if( pad_size.x <= 0 || pad_size.y <= 0 ) if( pad_size.x <= 0 || pad_size.y <= 0 )
warning_msgs.Add( _( "Warning: Pad size is less than zero." ) ); error_msgs.Add( _( "Error: Pad must have a positive size." ) );
} }
// Test hole against pad shape // Test hole against pad shape
@ -1452,10 +1452,12 @@ bool DIALOG_PAD_PROPERTIES::padValuesOK()
: _( "Pad Properties Warnings" ); : _( "Pad Properties Warnings" );
HTML_MESSAGE_BOX dlg( this, title ); HTML_MESSAGE_BOX dlg( this, title );
dlg.ListSet( error_msgs ); wxArrayString msgs = error_msgs;
if( warning_msgs.GetCount() ) for( const wxString& msg : warning_msgs )
dlg.ListSet( warning_msgs ); msgs.Add( msg );
dlg.ListSet( msgs );
dlg.ShowModal(); dlg.ShowModal();
} }