haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect behavior of BBOX_3D::GetMaxDimension()

This commit is contained in:
Mikolaj Wielgus 2021-10-24 19:00:46 +02:00 committed by Jon Evans
parent afccea34a5
commit 363214d252
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
3d-viewer/3d_rendering/raytracing/shapes3D/bbox_3d.cpp
View File

@ -166,17 +166,8 @@ unsigned int BBOX_3D::MaxDimension() const
float BBOX_3D::GetMaxDimension() const float BBOX_3D::GetMaxDimension() const
{ {
unsigned int max_dimensions_idx = 0;
SFVEC3F extent = GetExtent(); SFVEC3F extent = GetExtent();
return std::max( std::max( extent.x, extent.y ), extent.z );
if( extent.y > extent.x )
max_dimensions_idx = 1;
if( extent.z > extent.y )
max_dimensions_idx = 2;
return extent[max_dimensions_idx];
} }