haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

router: correctly assign owner via/pad to its hole when committing the world state 

fixes #14852
This commit is contained in:
Tomasz Wlostowski 2023-06-08 11:54:32 +02:00
parent 8a1220128b
commit 3667e4f6b2
1 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
pcbnew/router/pns_node.cpp
View File

@ -494,8 +494,11 @@ const ITEM_SET NODE::HitTest( const VECTOR2I& aPoint ) const
void NODE::addSolid( SOLID* aSolid )
{
if( aSolid->HasHole() && aSolid->Hole()->BelongsTo( aSolid ) )
if( aSolid->HasHole() )
{
assert( aSolid->Hole()->BelongsTo( aSolid ) );
addHole( aSolid->Hole() );
}
if( aSolid->IsRoutable() )
linkJoint( aSolid->Pos(), aSolid->Layers(), aSolid->Net(), aSolid );
@ -514,8 +517,14 @@ void NODE::Add( std::unique_ptr< SOLID >&& aSolid )
void NODE::addVia( VIA* aVia )
{
if( aVia->HasHole() && aVia->Hole()->BelongsTo( aVia ) )
if( aVia->HasHole() )
{
if( ! aVia->Hole()->BelongsTo( aVia ) )
{
assert( false );
}
addHole( aVia->Hole() );
}
linkJoint( aVia->Pos(), aVia->Layers(), aVia->Net(), aVia );
aVia->SetOwner( this );
@ -724,7 +733,7 @@ void NODE::doRemove( ITEM* aItem )
if( hole )
{
m_index->Remove( hole ); // hole is not directly owned by NODE but by the parent SOLID/VIA.
hole->SetOwner( hole->ParentPadVia() );
hole->SetOwner( aItem );
}
}
}
@ -834,6 +843,11 @@ void NODE::Remove( VIA* aVia )
{
removeViaIndex( aVia );
doRemove( aVia );
if( !aVia->Owner() )
{
assert( aVia->Hole()->BelongsTo( aVia ) );
}
}
@ -864,7 +878,10 @@ void NODE::Remove( ITEM* aItem )
SOLID* solid = static_cast<SOLID*>( aItem );
if( solid->HasHole() )
{
Remove( solid->Hole() );
solid->Hole()->SetOwner( solid );
}
Remove( static_cast<SOLID*>( aItem ) );
break;
@ -889,7 +906,10 @@ void NODE::Remove( ITEM* aItem )
VIA* via = static_cast<VIA*>( aItem );
if( via->HasHole() )
{
Remove( via->Hole() );
via->Hole()->SetOwner( via );
}
Remove( static_cast<VIA*>( aItem ) );
break;
@ -1433,6 +1453,11 @@ void NODE::Commit( NODE* aNode )
for( ITEM* item : *aNode->m_index )
{
if( item->HasHole() )
{
item->Hole()->SetOwner( item );
}
item->SetRank( -1 );
item->Unmark();
add( item );