Fix uninitialized member warnings

Based on PVS Studio report

eeschema/sch_plugins/cadstar/cadstar_sch_archive_parser.h

@@ -36,7 +36,7 @@ class CADSTAR_SCH_ARCHIVE_PARSER : public CADSTAR_ARCHIVE_PARSER
 {
 public:
     explicit CADSTAR_SCH_ARCHIVE_PARSER( wxString aFilename )
-            : CADSTAR_ARCHIVE_PARSER(), Filename( aFilename ), KiCadUnitDivider( 10 )
+            : CADSTAR_ARCHIVE_PARSER(), Filename( aFilename ), Header(), Assignments(), KiCadUnitDivider( 10 )
     {
     }
 

gerbview/gerbview_settings.cpp

@@ -34,11 +34,11 @@
 const int gerbviewSchemaVersion = 0;
 
 
-GERBVIEW_SETTINGS::GERBVIEW_SETTINGS() : APP_SETTINGS_BASE( "gerbview", gerbviewSchemaVersion )
+GERBVIEW_SETTINGS::GERBVIEW_SETTINGS() :
+        APP_SETTINGS_BASE( "gerbview", gerbviewSchemaVersion ),
+        m_BoardLayersCount( 2 ),
+        m_Appearance()
 {
-    // Make Coverity happy
-    m_BoardLayersCount = 2;
-
     // Init settings:
     m_params.emplace_back( new PARAM<bool>( "appearance.show_border_and_titleblock",
             &m_Appearance.show_border_and_titleblock, false ) );

include/basic_gal.h

@@ -61,14 +61,16 @@ class BASIC_GAL: public KIGFX::GAL
 {
 public:
     BASIC_GAL( KIGFX::GAL_DISPLAY_OPTIONS& aDisplayOptions ) :
-        GAL( aDisplayOptions )
+        GAL( aDisplayOptions ),
+        m_DC( nullptr ),
+        m_Color( RED ),
+        m_transform(),
+        m_clipBox(),
+        m_isClipped( false ),
+        m_callback( nullptr ),
+        m_callbackData( nullptr ),
+        m_plotter( nullptr )
     {
-        m_DC = nullptr;
-        m_Color = RED;
-        m_plotter = nullptr;
-        m_callback = nullptr;
-        m_callbackData = nullptr;
-        m_isClipped = false;
     }
 
     void SetPlotter( PLOTTER* aPlotter )

include/tool/conditional_menu.h

@@ -153,6 +153,7 @@ private:
         // Separator
         ENTRY( SELECTION_CONDITION aCondition, int aOrder ) :
             m_type( SEPARATOR ), m_icon( static_cast<BITMAPS>( 0 ) ),
+            m_data(),
             m_condition( aCondition ),
             m_order( aOrder ),
             m_isCheckmarkEntry( false )

include/widgets/mathplot.h

@@ -1731,11 +1731,16 @@ public:
     /** Default constructor (sets location and rotation to (0,0,0))
      */
     mpMovableObject() :
+        m_flags( 0 ),
         m_reference_x( 0 ),
         m_reference_y( 0 ),
         m_reference_phi( 0 ),
         m_shape_xs( 0 ),
-        m_shape_ys( 0 )
+        m_shape_ys( 0 ),
+        m_bbox_min_x( 0 ),
+        m_bbox_max_x( 0 ),
+        m_bbox_min_y( 0 ),
+        m_bbox_max_y( 0 )
     {
         m_type = mpLAYER_PLOT;
     }
@@ -1957,6 +1962,8 @@ public:
     {
         m_min_x = m_max_x =
                       m_min_y = m_max_y = 0;
+        m_scaledBitmap_offset_x = 0;
+        m_scaledBitmap_offset_y = 0;
         m_validImg = false;
         m_type = mpLAYER_BITMAP;
     }

pcbnew/drc/drc_rule.h

@@ -107,6 +107,7 @@ class DRC_CONSTRAINT
     DRC_CONSTRAINT( DRC_CONSTRAINT_T aType = NULL_CONSTRAINT,
                     const wxString& aName = wxEmptyString ) :
             m_Type( aType ),
+            m_Value(),
             m_DisallowFlags( 0 ),
             m_name( aName ),
             m_parentRule( nullptr )

pcbnew/pcb_expr_evaluator.cpp

@@ -1073,11 +1073,15 @@ PCB_EXPR_COMPILER::PCB_EXPR_COMPILER()
 }
 
 
-PCB_EXPR_EVALUATOR::PCB_EXPR_EVALUATOR()
+PCB_EXPR_EVALUATOR::PCB_EXPR_EVALUATOR() :
+    m_result( 0 ),
+    m_compiler(),
+    m_ucode(),
+    m_errorStatus()
 {
-    m_result = 0;
 }
 
+
 PCB_EXPR_EVALUATOR::~PCB_EXPR_EVALUATOR()
 {
 }

pcbnew/pcb_expr_evaluator.h

@@ -83,7 +83,7 @@ private:
 class PCB_EXPR_VAR_REF : public LIBEVAL::VAR_REF
 {
 public:
-    PCB_EXPR_VAR_REF( int aItemIndex ) : 
+    PCB_EXPR_VAR_REF( int aItemIndex ) :
         m_itemIndex( aItemIndex ),
         m_type( LIBEVAL::VT_UNDEFINED ),
         m_isEnum( false )

pcbnew/router/pns_joint.h

@@ -67,7 +67,7 @@ public:
     };
 
     JOINT() :
-        ITEM( JOINT_T ), m_locked( false ) {}
+        ITEM( JOINT_T ), m_tag(), m_locked( false ) {}
 
     JOINT( const VECTOR2I& aPos, const LAYER_RANGE& aLayers, int aNet = -1 ) :
         ITEM( JOINT_T )

pcbnew/router/pns_shove.h

@@ -100,6 +100,7 @@ private:
     {
         SPRINGBACK_TAG() :
             m_length( 0 ),
+            m_draggedVia(),
             m_node( nullptr ),
             m_seq( 0 ),
             m_locked( false )