Planning for PCB_BASE_FRAME::Save_Module_In_Library and PCB_EDIT_FRAME::ArchiveModulesOnBoard rewrites

TODO.txt

@@ -146,6 +146,10 @@ PCBNew
 
 Dick's Final TODO List:
 ======================
+*) Rewrite
+        PCB_BASE_FRAME::Save_Module_In_Library
+        PCB_EDIT_FRAME::ArchiveModulesOnBoard
+   to use FP_LIB_TABLE mechanisms.
 *) write options dialog for fp table dialog.
 *) Apply Fabrizio and Alexander's linux desktop patches after unifying them.
 *) Get licensing cleaned up.

pcbnew/module_editor_frame.h

@@ -432,8 +432,7 @@ protected:
      */
     void updateTitle();
 
-    // @todo these will eventually have to be made instance variables.
-    static wxString m_lib_nick_name;
+    wxString m_lib_nick_name;
 
     /// The library nickName is a short string, for now the same as the library path
     /// but without path and without extension.  After library table support it becomes
@@ -441,9 +440,10 @@ protected:
     wxString getLibNickName() const                     { return m_lib_nick_name; }
     void setLibNickName( const wxString& aLibNickName ) { m_lib_nick_name = aLibNickName; }
 
-    static wxString m_lib_path;
 
 #if !defined(USE_FP_LIB_TABLE)
+    wxString m_lib_path;
+
     void setLibPath( const wxString& aLibPath )         { m_lib_path = aLibPath; }
 
     /// The libPath is the full string used in the PLUGIN::Footprint*() calls.

pcbnew/moduleframe.cpp

@@ -53,9 +53,6 @@
 
 static PCB_SCREEN* s_screenModule;      // the PCB_SCREEN used by the footprint editor
 
-wxString FOOTPRINT_EDIT_FRAME::m_lib_nick_name;
-wxString FOOTPRINT_EDIT_FRAME::m_lib_path;
-
 BOARD* FOOTPRINT_EDIT_FRAME::s_Pcb;
 
 BEGIN_EVENT_TABLE( FOOTPRINT_EDIT_FRAME, PCB_BASE_FRAME )