haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up Coverity warning.

This commit is contained in:
Jeff Young 2020-09-03 12:47:51 +01:00
parent 38e9217d54
commit 3ce1b2b44e
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
eeschema/dialogs/dialog_edit_component_in_schematic.cpp
View File

@ -274,6 +274,11 @@ DIALOG_EDIT_COMPONENT_IN_SCHEMATIC::DIALOG_EDIT_COMPONENT_IN_SCHEMATIC( SCH_EDIT
{ {
m_comp = aComponent; m_comp = aComponent;
m_part = m_comp->GetPartRef().get(); m_part = m_comp->GetPartRef().get();
// GetPartRef() now points to the cached part in the schematic, which should always be
// there
wxASSERT( m_part );
m_fields = new FIELDS_GRID_TABLE<SCH_FIELD>( this, aParent, m_part ); m_fields = new FIELDS_GRID_TABLE<SCH_FIELD>( this, aParent, m_part );
m_width = 0; m_width = 0;
@ -431,13 +436,15 @@ bool DIALOG_EDIT_COMPONENT_IN_SCHEMATIC::TransferDataToWindow()
m_unitChoice->Enable( false ); m_unitChoice->Enable( false );
} }
if( m_part != nullptr && m_part->HasConversion() ) if( m_part->HasConversion() )
{ {
if( m_comp->GetConvert() > LIB_ITEM::LIB_CONVERT::BASE ) if( m_comp->GetConvert() > LIB_ITEM::LIB_CONVERT::BASE )
m_cbAlternateSymbol->SetValue( true ); m_cbAlternateSymbol->SetValue( true );
} }
else else
{
m_cbAlternateSymbol->Enable( false ); m_cbAlternateSymbol->Enable( false );
}
// Set the symbol orientation and mirroring. // Set the symbol orientation and mirroring.
int orientation = m_comp->GetOrientation() & ~( CMP_MIRROR_X | CMP_MIRROR_Y ); int orientation = m_comp->GetOrientation() & ~( CMP_MIRROR_X | CMP_MIRROR_Y );