haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DIALOG_CONFIGURE_PATHS: fix issue: html help window never destroyed. 

Once the help button is clicked, the html help window is created but never destroyed.
It prevent Kicad to be fully closed
(closing Kicad does not fully close Kicad and leave something like a zombie process)
This commit is contained in:
jean-pierre charras 2020-12-07 10:28:54 +01:00
parent 59527dff2a
commit 413ff4525b
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
common/dialogs/dialog_configure_paths.cpp
View File

@ -567,6 +567,12 @@ void DIALOG_CONFIGURE_PATHS::OnGridSize( wxSizeEvent& event )
void DIALOG_CONFIGURE_PATHS::OnHelp( wxCommandEvent& event )
{
if( m_helpDialog )
{
m_helpDialog->ShowModeless();
return;
}
wxString msg = _( "Enter the name and value for each environment variable. Grey entries "
"are names that have been defined externally at the system or user "
"level. Environment variables defined at the system or user level "
@ -588,9 +594,11 @@ void DIALOG_CONFIGURE_PATHS::OnHelp( wxCommandEvent& event )
}
HTML_MESSAGE_BOX* dlg = new HTML_MESSAGE_BOX( nullptr, _( "Environment Variable Help" ) );
dlg->SetDialogSizeInDU( 400, 250 );
m_helpDialog = new HTML_MESSAGE_BOX( nullptr, _( "Environment Variable Help" ) );
m_helpDialog->SetDialogSizeInDU( 400, 250 );
dlg->AddHTML_Text( msg );
dlg->ShowModeless();
m_helpDialog->AddHTML_Text( msg );
m_helpDialog->ShowModeless();
// m_helpDialog will be destroyed when closing the dialog
}