haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pcbnew: don't fallback to software rendering after changing footprint 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8915
This commit is contained in:
Mike Williams 2021-08-26 11:24:52 -04:00 committed by Seth Hillbrand
parent ee5f9034f7
commit 43194dff72
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pcbnew/pcb_edit_frame.cpp
View File

@ -1544,11 +1544,21 @@ void PCB_EDIT_FRAME::ShowFootprintPropertiesDialog( FOOTPRINT* aFootprint )
if( aFootprint == nullptr ) if( aFootprint == nullptr )
return; return;
DIALOG_FOOTPRINT_PROPERTIES dlg( this, aFootprint ); DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_RETVALUE retvalue;
/*
* Make sure dlg is destroyed before GetCanvas->Refresh is called
* later or the refresh will try to modify its properties since
* they share a GL context.
*/
{
DIALOG_FOOTPRINT_PROPERTIES dlg( this, aFootprint );
// We use quasi modal to allow displaying help dialogs.
dlg.ShowQuasiModal();
retvalue = dlg.GetReturnValue();
}
// We use quasi modal to allow displaying help dialogs.
dlg.ShowQuasiModal();
DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_RETVALUE retvalue = dlg.GetReturnValue();
/* /*
* retvalue = * retvalue =
* FP_PROPS_UPDATE_FP to show Update Footprints dialog * FP_PROPS_UPDATE_FP to show Update Footprints dialog