haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CADSTAR PCB: Correctly handle associated pad ids and PCB Only pads 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9372
This commit is contained in:
Roberto Fernandez Bautista 2021-10-11 16:41:36 +01:00
parent 759abb7928
commit 43e59b0ea7
1 changed files with 16 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
pcbnew/plugins/cadstar/cadstar_pcb_archive_loader.cpp
View File

@ -807,28 +807,13 @@ void CADSTAR_PCB_ARCHIVE_LOADER::loadLibraryCoppers( const SYMDEF_PCB& aComponen
m_librarycopperpads[aComponent.ID][anchorPad.ID].push_back( aFootprint->Pads().size() );
totalCopperPads++;
// Now renumber all the associated pads if they are PCB Only
int numRenames = 0;
// Now renumber all the associated pads
COMPONENT_PAD associatedPad;
for( PAD_ID padID : compCopper.AssociatedPadIDs )
{
associatedPad = aComponent.ComponentPads.at( padID );
if( associatedPad.PCBonlyPad )
{
PAD* assocPad = getPadReference( aFootprint, padID );
assocPad->SetNumber( pad->GetNumber() );
++numRenames;
}
}
if( numRenames < compCopper.AssociatedPadIDs.size() - 1 )
{
// This is an older design of thermal pad. The schematic will
// have multiple pins for the same pad, so lets use the
// "allow thermal pads" hack
aFootprint->SetKeywords( wxT( "allow thermal pads" ) );
PAD* assocPad = getPadReference( aFootprint, padID );
assocPad->SetNumber( pad->GetNumber() );
}
}
else
@ -982,9 +967,19 @@ PAD* CADSTAR_PCB_ARCHIVE_LOADER::getKiCadPad( const COMPONENT_PAD& aCadstarPad,
pad->SetLayerSet( padLayerSet );
pad->SetNumber( aCadstarPad.Identifier.IsEmpty() ?
wxString::Format( wxT( "%ld" ), aCadstarPad.ID ) :
aCadstarPad.Identifier );
if( aCadstarPad.PCBonlyPad )
{
// PCB Only pads in CADSTAR do not have a representation in the schematic - they are
// purely mechanical pads that have no net associated with them. Make the pad name
// empty to avoid warnings when importing from the schematic
pad->SetNumber( wxT( "" ) );
}
else
{
pad->SetNumber( aCadstarPad.Identifier.IsEmpty()
? wxString::Format( wxT( "%ld" ), aCadstarPad.ID )
: aCadstarPad.Identifier );
}
if( csPadcode.Shape.Size == 0 )
{