Add batch edit for visible flag.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14519
This commit is contained in:
Jeff Young 2023-09-26 00:31:08 +01:00
parent 7010f7963c
commit 43edbcc622
2 changed files with 28 additions and 2 deletions

View File

@ -36,6 +36,8 @@ void LIB_TABLE_GRID_TRICKS::showPopupMenu( wxMenu& menu, wxGridEvent& aEvent )
bool showActivate = false; bool showActivate = false;
bool showDeactivate = false; bool showDeactivate = false;
bool showSetVisible = false;
bool showUnsetVisible = false;
LIB_TABLE_GRID* tbl = static_cast<LIB_TABLE_GRID*>( m_grid->GetTable() ); LIB_TABLE_GRID* tbl = static_cast<LIB_TABLE_GRID*>( m_grid->GetTable() );
// Ensure selection parameters are up to date // Ensure selection parameters are up to date
@ -48,7 +50,12 @@ void LIB_TABLE_GRID_TRICKS::showPopupMenu( wxMenu& menu, wxGridEvent& aEvent )
else else
showActivate = true; showActivate = true;
if( showActivate && showDeactivate ) if( tbl->GetValueAsBool( row, 1 ) )
showUnsetVisible = true;
else
showSetVisible = true;
if( showActivate && showDeactivate && showSetVisible && showUnsetVisible )
break; break;
} }
@ -58,6 +65,12 @@ void LIB_TABLE_GRID_TRICKS::showPopupMenu( wxMenu& menu, wxGridEvent& aEvent )
if( showDeactivate ) if( showDeactivate )
menu.Append( LIB_TABLE_GRID_TRICKS_DEACTIVATE_SELECTED, _( "Deactivate selected" ) ); menu.Append( LIB_TABLE_GRID_TRICKS_DEACTIVATE_SELECTED, _( "Deactivate selected" ) );
if( showSetVisible )
menu.Append( LIB_TABLE_GRID_TRICKS_SET_VISIBLE, _( "Set visible flag" ) );
if( showUnsetVisible )
menu.Append( LIB_TABLE_GRID_TRICKS_UNSET_VISIBLE, _( "Unset visible flag" ) );
bool showSettings = false; bool showSettings = false;
if( m_sel_row_count == 1 && tbl->At( m_sel_row_start )->SupportsSettingsDialog() ) if( m_sel_row_count == 1 && tbl->At( m_sel_row_start )->SupportsSettingsDialog() )
@ -68,7 +81,7 @@ void LIB_TABLE_GRID_TRICKS::showPopupMenu( wxMenu& menu, wxGridEvent& aEvent )
tbl->GetValue( m_sel_row_start, 2 ) ) ); tbl->GetValue( m_sel_row_start, 2 ) ) );
} }
if( showActivate || showDeactivate || showSettings ) if( showActivate || showDeactivate || showSetVisible || showUnsetVisible || showSettings )
menu.AppendSeparator(); menu.AppendSeparator();
GRID_TRICKS::showPopupMenu( menu, aEvent ); GRID_TRICKS::showPopupMenu( menu, aEvent );
@ -95,6 +108,17 @@ void LIB_TABLE_GRID_TRICKS::doPopupSelection( wxCommandEvent& event )
// Ensure the new state (on/off) of the widgets is immediately shown: // Ensure the new state (on/off) of the widgets is immediately shown:
m_grid->Refresh(); m_grid->Refresh();
} }
else if( menu_id == LIB_TABLE_GRID_TRICKS_SET_VISIBLE
|| menu_id == LIB_TABLE_GRID_TRICKS_UNSET_VISIBLE )
{
bool selected_state = menu_id == LIB_TABLE_GRID_TRICKS_SET_VISIBLE;
for( int row = m_sel_row_start; row < m_sel_row_start + m_sel_row_count; ++row )
tbl->SetValueAsBool( row, 1, selected_state );
// Ensure the new state (on/off) of the widgets is immediately shown:
m_grid->Refresh();
}
else if( menu_id == LIB_TABLE_GRID_TRICKS_LIBRARY_SETTINGS ) else if( menu_id == LIB_TABLE_GRID_TRICKS_LIBRARY_SETTINGS )
{ {
LIB_TABLE_ROW* row = tbl->At( m_sel_row_start ); LIB_TABLE_ROW* row = tbl->At( m_sel_row_start );

View File

@ -25,6 +25,8 @@ class LIB_TABLE_GRID_TRICKS : public GRID_TRICKS
{ {
LIB_TABLE_GRID_TRICKS_ACTIVATE_SELECTED = GRIDTRICKS_FIRST_CLIENT_ID, LIB_TABLE_GRID_TRICKS_ACTIVATE_SELECTED = GRIDTRICKS_FIRST_CLIENT_ID,
LIB_TABLE_GRID_TRICKS_DEACTIVATE_SELECTED, LIB_TABLE_GRID_TRICKS_DEACTIVATE_SELECTED,
LIB_TABLE_GRID_TRICKS_SET_VISIBLE,
LIB_TABLE_GRID_TRICKS_UNSET_VISIBLE,
LIB_TABLE_GRID_TRICKS_LIBRARY_SETTINGS, LIB_TABLE_GRID_TRICKS_LIBRARY_SETTINGS,
LIB_TABLE_GRID_TRICKS_OPTIONS_EDITOR LIB_TABLE_GRID_TRICKS_OPTIONS_EDITOR
}; };