haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unify rounding in altium to KiCad converter 

This fixes an issue in the integer conversion that caused truncation
errors.  Handling the conversion from micromil to nanometer using
doubles keeps intermediate values correctly rounded.  There remain some
conversions that are lost where Altium rounded its metric
representation.
This commit is contained in:
Seth Hillbrand 2020-06-14 07:53:15 -07:00
parent 899496baaa
commit 461d0e9a49
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pcbnew/altium2kicadpcb_plugin/altium_parser.h
View File

@ -2,6 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2019-2020 Thomas Pointhuber <thomas.pointhuber@gmx.at>
* Copyright (C) 2020 KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
@ -120,14 +121,11 @@ public:
std::map<wxString, wxString> ReadProperties();
static int32_t ConvertToKicadUnit( const int32_t aValue )
{
return ( ( (int64_t) aValue ) * 254L ) / 100;
}
static int32_t ConvertToKicadUnit( const double aValue )
{
return KiROUND( aValue * 2.54L );
double int_limit = std::numeric_limits<int>::max() * 0.7071; // 0.7071 = roughly 1/sqrt(2)
return KiROUND( Clamp<double>( -int_limit, aValue * 2.54, int_limit ) );
}
static int PropertiesReadInt(