haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure footprints are removed from group before exporting to library 

Duplicating a footprint automatically adds it to the group the original
is contained in, and these copies should not be part of the board after
their use.

Fixes KICAD-5YC
This commit is contained in:
Ian McInerney 2024-01-03 00:19:29 +00:00
parent d0a3c04835
commit 4770532511
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pcbnew/footprint_libraries_utils.cpp
View File

@ -590,6 +590,13 @@ void PCB_EDIT_FRAME::ExportFootprintsToLibrary( bool aStoreInNewLib, const wxStr
aFootprint->SetReference( "REF**" );
};
auto resetGroup =
[]( FOOTPRINT* aFootprint )
{
if( PCB_GROUP* parentGroup = aFootprint->GetParentGroup() )
parentGroup->RemoveItem( aFootprint );
};
if( !aStoreInNewLib )
{
// The footprints are saved in an existing .pretty library in the fp lib table
@ -615,7 +622,10 @@ void PCB_EDIT_FRAME::ExportFootprintsToLibrary( bool aStoreInNewLib, const wxStr
{
FOOTPRINT* fpCopy = static_cast<FOOTPRINT*>( footprint->Duplicate() );
// Reset reference designator and group membership before saving
resetReference( fpCopy );
resetGroup( fpCopy );
tbl->FootprintSave( nickname, fpCopy, true );
delete fpCopy;
@ -668,12 +678,11 @@ void PCB_EDIT_FRAME::ExportFootprintsToLibrary( bool aStoreInNewLib, const wxStr
{
FOOTPRINT* fpCopy = static_cast<FOOTPRINT*>( footprint->Duplicate() );
// Reset reference designator and group membership before saving
resetReference( fpCopy );
pi->FootprintSave( libPath, fpCopy );
resetGroup( fpCopy );
// Remove reference to the group before deleting
if( PCB_GROUP* parentGroup = fpCopy->GetParentGroup() )
parentGroup->RemoveItem( fpCopy );
pi->FootprintSave( libPath, fpCopy );
delete fpCopy;
}