haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't allocate/delete a PG_UNIT_EDITOR unless needed 

We cannot actually delete the PG_UNIT_EDITOR without substantial issues
from the global variables in wx.
This commit is contained in:
Seth Hillbrand 2022-12-04 10:25:57 -08:00
parent 1b18e1eb6a
commit 47e7cd2e90
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pcbnew/widgets/pcb_properties_panel.cpp
View File

@ -42,11 +42,9 @@ PCB_PROPERTIES_PANEL::PCB_PROPERTIES_PANEL( wxWindow* aParent, PCB_EDIT_FRAME* a
m_propMgr.Rebuild(); m_propMgr.Rebuild();
bool found = false; bool found = false;
PG_UNIT_EDITOR* new_editor = new PG_UNIT_EDITOR( m_frame );
if( wxPGGlobalVars ) if( wxPGGlobalVars )
{ {
auto it = wxPGGlobalVars->m_mapEditorClasses.find( new_editor->GetName() ); auto it = wxPGGlobalVars->m_mapEditorClasses.find( PG_UNIT_EDITOR::EDITOR_NAME );
if( it != wxPGGlobalVars->m_mapEditorClasses.end() ) if( it != wxPGGlobalVars->m_mapEditorClasses.end() )
{ {
@ -56,10 +54,11 @@ PCB_PROPERTIES_PANEL::PCB_PROPERTIES_PANEL( wxWindow* aParent, PCB_EDIT_FRAME* a
} }
} }
if( found ) if( !found )
delete new_editor; {
else PG_UNIT_EDITOR* new_editor = new PG_UNIT_EDITOR( m_frame );
m_editor = static_cast<PG_UNIT_EDITOR*>( wxPropertyGrid::RegisterEditorClass( new_editor ) ); m_editor = static_cast<PG_UNIT_EDITOR*>( wxPropertyGrid::RegisterEditorClass( new_editor ) );
}
} }