haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Streamline explodePad undo. 

Also fixes a bug where new shapes were added to the view
twice.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16888
This commit is contained in:
Jeff Young 2024-02-09 10:06:16 +00:00
parent 037f349585
commit 4905c37712
2 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pcbnew/tools/pad_tool.cpp
View File

@ -679,12 +679,7 @@ int PAD_TOOL::EditPad( const TOOL_EVENT& aEvent )
BOARD_COMMIT commit( frame() );
commit.Modify( pad );
std::vector<PCB_SHAPE*> newShapes = explodePad( pad, &layer );
for( PCB_SHAPE* shape : newShapes )
commit.Added( shape );
explodePad( pad, &layer, commit );
commit.Push( _( "Edit Pad" ) );
m_toolMgr->RunAction( PCB_ACTIONS::selectionClear );
@ -803,10 +798,8 @@ void PAD_TOOL::ExitPadEditMode()
}
std::vector<PCB_SHAPE*> PAD_TOOL::explodePad( PAD* aPad, PCB_LAYER_ID* aLayer )
void PAD_TOOL::explodePad( PAD* aPad, PCB_LAYER_ID* aLayer, BOARD_COMMIT& aCommit )
{
std::vector<PCB_SHAPE*> createdShapes;
if( aPad->IsOnLayer( F_Cu ) )
*aLayer = F_Cu;
else if( aPad->IsOnLayer( B_Cu ) )
@ -833,9 +826,7 @@ std::vector<PCB_SHAPE*> PAD_TOOL::explodePad( PAD* aPad, PCB_LAYER_ID* aLayer )
shape->SetWidth( pcbIUScale.mmToIU( ZONE_THERMAL_RELIEF_COPPER_WIDTH_MM ) );
}
board()->GetFirstFootprint()->Add( shape );
frame()->GetCanvas()->GetView()->Add( shape );
createdShapes.push_back( shape );
aCommit.Add( shape );
}
aPad->SetShape( aPad->GetAnchorPadShape() );
@ -844,8 +835,6 @@ std::vector<PCB_SHAPE*> PAD_TOOL::explodePad( PAD* aPad, PCB_LAYER_ID* aLayer )
aPad->SetFlags( ENTERED );
m_editPad = aPad->m_Uuid;
return createdShapes;
}

2
pcbnew/tools/pad_tool.h
View File

@ -89,7 +89,7 @@ private:
///< Push pad settings from a pad to other pads on board or footprint.
int pushPadSettings( const TOOL_EVENT& aEvent );
std::vector<PCB_SHAPE*> explodePad( PAD* aPad, PCB_LAYER_ID* aLayer );
void explodePad( PAD* aPad, PCB_LAYER_ID* aLayer, BOARD_COMMIT& aCommit );
void enterPadEditMode();