haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drc_test_provider_library_parity: fix false positive. 

After last changes in PCB_SHAPES, there were issues when comparing coordinates
of shapes.
Use now a footprint not flipped, not rotated and at position 0,0 for comparisons.
Fixes #14496
https://gitlab.com/kicad/code/kicad/issues/14496
This commit is contained in:
jean-pierre charras 2023-04-05 18:25:19 +02:00
parent 33da9b2327
commit 4d05bd62da
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pcbnew/drc/drc_test_provider_library_parity.cpp
View File

@ -455,13 +455,24 @@ bool FOOTPRINT::FootprintNeedsUpdate( const FOOTPRINT* aLibFootprint, REPORTER*
wxASSERT( aLibFootprint ); wxASSERT( aLibFootprint );
bool diff = false; bool diff = false;
if( IsFlipped() ) // To avoid issues when comparing the footprint on board and the footprint in library
// use a footprint not flipped, not rotated and at position 0,0.
// Otherwise one can see differences when comparing coordinates of some items
if( IsFlipped() || GetPosition() != VECTOR2I( 0, 0 ) || GetOrientation() != ANGLE_0 )
{ {
std::unique_ptr<FOOTPRINT> temp( static_cast<FOOTPRINT*>( Clone() ) ); std::unique_ptr<FOOTPRINT> temp( static_cast<FOOTPRINT*>( Clone() ) );
temp->Flip( {0,0}, false );
temp->SetParentGroup( nullptr ); temp->SetParentGroup( nullptr );
diff = temp->FootprintNeedsUpdate( aLibFootprint ); if( IsFlipped() )
temp->Flip( {0,0}, false );
if( GetPosition() != VECTOR2I( 0, 0 ) )
temp->SetPosition( { 0, 0 } );
if( GetOrientation() != ANGLE_0 )
temp->SetOrientation( ANGLE_0 );
diff = temp->FootprintNeedsUpdate( aLibFootprint, aReporter );
// This temporary footprint must not have a parent when it goes out of scope because it must // This temporary footprint must not have a parent when it goes out of scope because it must
// not trigger the IncrementTimestamp call in ~FOOTPRINT. // not trigger the IncrementTimestamp call in ~FOOTPRINT.