haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some warnings detected by PVS-STUDIO (not used vars)

This commit is contained in:
jean-pierre charras 2022-07-26 11:58:35 +02:00
parent ee0f93ed17
commit 4d48376eae
30 changed files with 8 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gerbview/dialogs/dialog_print_gerbview.cpp
View File

@ -124,7 +124,6 @@ bool DIALOG_PRINT_GERBVIEW::TransferDataToWindow()
// Create layer list
for( unsigned ii = 0; ii < images->ImagesMaxCount(); ++ii )
{
wxString layerName;
unsigned int listIdx = itemIdx / LAYER_PER_LIST;
if( listIdx >= LAYER_LIST_COUNT )

1
gerbview/job_file_reader.cpp
View File

@ -115,7 +115,6 @@ bool GERBER_JOBFILE_READER::ReadGerberJobFile()
FILE_LINE_READER jobfileReader( jobFile, m_filename.GetFullPath() ); // Will close jobFile
wxString msg;
wxString data;
// detect the file format: old (deprecated) gerber format of official JSON format

1
kicad/project_tree_item.cpp
View File

@ -173,7 +173,6 @@ void PROJECT_TREE_ITEM::Delete()
void PROJECT_TREE_ITEM::Activate( PROJECT_TREE_PANE* aTreePrjFrame )
{
wxString sep = wxFileName::GetPathSeparator();
wxString fullFileName = GetFileName();
wxTreeItemId id = GetId();
std::string packet;

2
kicad/project_tree_pane.cpp
View File

@ -647,8 +647,6 @@ void PROJECT_TREE_PANE::onRight( wxTreeEvent& Event )
can_delete = item->CanDelete();
can_rename = item->CanRename();
wxString full_file_name = item->GetFileName();
switch( item->GetType() )
{
case TREE_FILE_TYPE::LEGACY_PROJECT:

2
kicad/tools/kicad_manager_control.cpp
View File

@ -138,7 +138,6 @@ int KICAD_MANAGER_CONTROL::NewFromTemplate( const TOOL_EVENT& aEvent )
DIALOG_TEMPLATE_SELECTOR* ps = new DIALOG_TEMPLATE_SELECTOR( m_frame );
wxFileName templatePath;
wxString envStr;
// KiCad system template path.
ENV_VAR_MAP_CITER it = Pgm().GetLocalEnvVariables().find( "KICAD6_TEMPLATE_DIR" );
@ -212,7 +211,6 @@ int KICAD_MANAGER_CONTROL::NewFromTemplate( const TOOL_EVENT& aEvent )
fn.AppendDir( fn.GetName() );
// Check if the project directory is empty if it already exists.
wxDir directory( fn.GetPath() );
if( !fn.DirExists() )
{

2
pagelayout_editor/toolbars_pl_editor.cpp
View File

@ -40,8 +40,6 @@ void PL_EDITOR_FRAME::ReCreateHToolbar()
m_mainToolBar->SetAuiManager( &m_auimgr );
}
wxString msg;
m_mainToolBar->Add( ACTIONS::doNew );
m_mainToolBar->Add( ACTIONS::open );
m_mainToolBar->Add( ACTIONS::save );

1
pcb_calculator/calculator_panels/panel_cable_size.cpp
View File

@ -146,7 +146,6 @@ void PANEL_CABLE_SIZE::OnCableSizeChange( wxCommandEvent& aEvent )
{
double value;
int index = m_sizeChoice->GetSelection();
wxString str;
if( ( index >= 0 ) && ( index < m_entries.size() ) )
{

1
pcb_calculator/calculator_panels/panel_fusing_current.cpp
View File

@ -41,7 +41,6 @@ PANEL_FUSING_CURRENT::PANEL_FUSING_CURRENT( wxWindow * parent, wxWindowID id,
PANEL_FUSING_CURRENT_BASE( parent, id, pos, size, style, name )
{
// Set some defaults
wxString wxs( "" );
m_ambientValue->SetValue( wxString::Format( wxT( "%i" ), 25 ) );
m_meltingValue->SetValue( wxString::Format( wxT( "%i" ), 1084 ) ); // Value for copper
m_meltingValue->SetEditable( false ); // For now, this panel only works for copper.

2
pcb_calculator/calculator_panels/panel_track_width.cpp
View File

@ -445,8 +445,6 @@ double PANEL_TRACK_WIDTH::TWCalculateCurrent( double aWidth, double aThickness,
void PANEL_TRACK_WIDTH::LoadSettings( PCB_CALCULATOR_SETTINGS* aCfg )
{
wxString msg;
// Disable calculations while we initialise.
m_TWNested = true;

1
pcb_calculator/eserie.cpp
View File

@ -182,7 +182,6 @@ void E_SERIE::combine4( uint32_t aSize )
{
uint32_t i,j;
double tmp;
std::string s;
m_results.at( S4R ).e_use = false; // disable 4R solution, until
m_results.at( S4R ).e_value = m_results.at( S3R ).e_value; // 4R becomes better than 3R solution

9
pcbnew/autorouter/ar_autoplacer.cpp
View File

@ -611,11 +611,12 @@ int AR_AUTOPLACER::getOptimalFPPlacement( FOOTPRINT* aFootprint )
{
lastPosOK = m_curPosition;
min_cost = Score;
/*
wxString msg;
/* msg.Printf( wxT( "Score %g, pos %s, %s" ),
msg.Printf( wxT( "Score %g, pos %s, %s" ),
min_cost,
GetChars( ::CoordinateToString( LastPosOK.x ) ),
GetChars( ::CoordinateToString( LastPosOK.y ) ) );
::CoordinateToString( LastPosOK.x ),
::CoordinateToString( LastPosOK.y ) );
m_frame->SetStatusText( msg );*/
}
}
@ -882,7 +883,6 @@ AR_RESULT AR_AUTOPLACER::AutoplaceFootprints( std::vector<FOOTPRINT*>& aFootprin
int cnt = 0;
wxString msg;
if( m_progressReporter )
{
@ -900,7 +900,6 @@ AR_RESULT AR_AUTOPLACER::AutoplaceFootprints( std::vector<FOOTPRINT*>& aFootprin
while( ( footprint = pickFootprint() ) != nullptr )
{
// Display some info about activity, footprint placement can take a while:
//m_frame->SetStatusText( msg );
if( m_progressReporter )
m_progressReporter->SetTitle( wxString::Format( _( "Autoplacing %s" ),

1
pcbnew/connectivity/from_to_cache.cpp
View File

@ -140,7 +140,6 @@ int FROM_TO_CACHE::cacheFromToPaths( const wxString& aFrom, const wxString& aTo
for( FT_PATH& path : paths )
{
int count = 0;
auto netName = path.from->GetNetname();
wxString fromName = path.from->GetParent()->GetReference() + wxT( "-" )
+ path.from->GetNumber();

2
pcbnew/dialogs/dialog_board_reannotate.cpp
View File

@ -300,8 +300,6 @@ void DIALOG_BOARD_REANNOTATE::OnApplyClick( wxCommandEvent& event )
void DIALOG_BOARD_REANNOTATE::MakeSampleText( wxString& aMessage )
{
wxString tmp;
aMessage.Printf( _( "\n%s footprints will be reannotated." ),
_( AnnotateString[m_annotationScope] ) );

1
pcbnew/dialogs/dialog_exchange_footprints.cpp
View File

@ -315,7 +315,6 @@ void DIALOG_EXCHANGE_FOOTPRINTS::OnOKClicked( wxCommandEvent& event )
void DIALOG_EXCHANGE_FOOTPRINTS::processMatchingFootprints()
{
LIB_ID newFPID;
wxString value;
if( m_parent->GetBoard()->Footprints().empty() )
return;

1
pcbnew/dialogs/dialog_footprint_wizard_list.cpp
View File

@ -107,7 +107,6 @@ void DIALOG_FOOTPRINT_WIZARD_LIST::initLists()
FOOTPRINT_WIZARD *wizard = FOOTPRINT_WIZARD_LIST::GetWizard( ii );
wxString name = wizard->GetName();
wxString description = wizard->GetDescription();
wxString image = wizard->GetImage();
m_footprintGeneratorsGrid->SetCellValue( ii, FP_GEN_ROW_NUMBER, num );
m_footprintGeneratorsGrid->SetCellValue( ii, FP_GEN_ROW_NAME, name );

2
pcbnew/dialogs/dialog_gendrill.cpp
View File

@ -326,8 +326,6 @@ void DIALOG_GENDRILL::OnOutputDirectoryBrowseClicked( wxCommandEvent& event )
void DIALOG_GENDRILL::UpdateDrillParams()
{
wxString msg;
// Set output directory and replace backslashes with forward ones
wxString dirStr;
dirStr = m_outputDirectoryName->GetValue();

6
pcbnew/dialogs/dialog_pad_properties.cpp
View File

@ -1245,7 +1245,6 @@ bool DIALOG_PAD_PROPERTIES::padValuesOK()
wxArrayString error_msgs;
wxArrayString warning_msgs;
wxString msg;
VECTOR2I pad_size = m_dummyPad->GetSize();
VECTOR2I drill_size = m_dummyPad->GetDrillSize();
@ -1732,14 +1731,15 @@ void DIALOG_PAD_PROPERTIES::updatePadSizeControls()
bool DIALOG_PAD_PROPERTIES::transferDataToPad( PAD* aPad )
{
wxString msg;
if( !Validate() )
return false;
if( !m_panelGeneral->Validate() )
return false;
if( !m_localSettingsPanel->Validate() )
return false;
if( !m_spokeWidth.Validate( 0, INT_MAX ) )
return false;

1
pcbnew/dialogs/panel_setup_layers.cpp
View File

@ -419,7 +419,6 @@ void PANEL_SETUP_LAYERS::OnCheckBox( wxCommandEvent& event )
void PANEL_SETUP_LAYERS::DenyChangeCheckBox( wxCommandEvent& event )
{
wxObject* source = event.GetEventObject();
wxString msg;
for( LSEQ seq = LSET::AllCuMask().Seq(); seq; ++seq )
{

1
pcbnew/dialogs/panel_setup_rules.cpp
View File

@ -102,7 +102,6 @@ void PANEL_SETUP_RULES::onCharHook( wxKeyEvent& aEvent )
void PANEL_SETUP_RULES::OnContextMenu(wxMouseEvent &event)
{
wxMenu menu;
wxString msg;
menu.Append( wxID_UNDO, _( "Undo" ) );
menu.Append( wxID_REDO, _( "Redo" ) );

2
pcbnew/exporters/export_d356.cpp
View File

@ -370,7 +370,7 @@ void IPC356D_WRITER::Write( const wxString& aFilename )
void PCB_EDIT_FRAME::GenD356File( wxCommandEvent& aEvent )
{
wxFileName fn = GetBoard()->GetFileName();
wxString msg, ext, wildcard;
wxString ext, wildcard;
ext = IpcD356FileExtension;
wildcard = IpcD356FileWildcard();

2
pcbnew/exporters/gerber_jobfile_writer.cpp
View File

@ -166,8 +166,6 @@ bool GERBER_JOBFILE_WRITER::CreateJobFile( const wxString& aFullFilename )
void GERBER_JOBFILE_WRITER::addJSONHeader()
{
wxString text;
m_json["Header"] = {
{
"GenerationSoftware",

2
pcbnew/footprint_edit_frame.cpp
View File

@ -1241,8 +1241,6 @@ void FOOTPRINT_EDIT_FRAME::CommonSettingsChanged( bool aEnvVarsChanged, bool aTe
void FOOTPRINT_EDIT_FRAME::OnSaveFootprintAsPng( wxCommandEvent& event )
{
wxString fullFileName;
LIB_ID id = GetLoadedFPID();
if( id.empty() )

1
pcbnew/footprint_viewer_frame.cpp
View File

@ -1163,7 +1163,6 @@ void FOOTPRINT_VIEWER_FRAME::OnIterateFootprintList( wxCommandEvent& event )
void FOOTPRINT_VIEWER_FRAME::UpdateTitle()
{
wxString title;
wxString path;
if( !getCurNickname().IsEmpty() )
{

2
pcbnew/pcb_dimension.cpp
View File

@ -1084,8 +1084,6 @@ void PCB_DIM_LEADER::updateGeometry()
void PCB_DIM_LEADER::GetMsgPanelInfo( EDA_DRAW_FRAME* aFrame, std::vector<MSG_PANEL_ITEM>& aList )
{
wxString msg;
aList.emplace_back( _( "Leader" ), m_text.GetShownText() );
ORIGIN_TRANSFORMS originTransforms = aFrame->GetOriginTransforms();

2
pcbnew/pcb_track.cpp
View File

@ -852,8 +852,6 @@ void PCB_VIA::GetMsgPanelInfo( EDA_DRAW_FRAME* aFrame, std::vector<MSG_PANEL_ITE
void PCB_TRACK::GetMsgPanelInfoBase_Common( EDA_DRAW_FRAME* aFrame,
std::vector<MSG_PANEL_ITEM>& aList ) const
{
wxString msg;
aList.emplace_back( _( "Net" ), UnescapeString( GetNetname() ) );
aList.emplace_back( _( "Net Class" ), UnescapeString( GetNetClass()->GetName() ) );

1
pcbnew/python/scripting/pcbnew_footprint_wizards.cpp
View File

@ -117,7 +117,6 @@ wxArrayString PYTHON_FOOTPRINT_WIZARD::CallRetArrayStrMethod( const char* aMet
PyObject* aArglist )
{
wxArrayString ret;
wxString str_item;
PyLOCK lock;
PyObject* result = CallMethod( aMethod, aArglist );

1
pcbnew/python/scripting/pcbnew_scripting_helpers.cpp
View File

@ -260,7 +260,6 @@ bool SaveBoard( wxString& aFileName, BOARD* aBoard, IO_MGR::PCB_FILE_T aFormat,
wxFileName pro = aFileName;
pro.SetExt( ProjectFileExtension );
pro.MakeAbsolute();
wxString projectPath = pro.GetFullPath();
GetSettingsManager()->SaveProjectAs( pro.GetFullPath(), aBoard->GetProject() );
}

2
pcbnew/toolbars_footprint_editor.cpp
View File

@ -54,8 +54,6 @@ void FOOTPRINT_EDIT_FRAME::ReCreateHToolbar()
m_mainToolBar->SetAuiManager( &m_auimgr );
}
wxString msg;
// Set up toolbar
m_mainToolBar->Add( PCB_ACTIONS::newFootprint );
m_mainToolBar->Add( PCB_ACTIONS::createFootprint );

2
pcbnew/tools/footprint_editor_control.cpp
View File

@ -367,8 +367,6 @@ int FOOTPRINT_EDITOR_CONTROL::PasteFootprint( const TOOL_EVENT& aEvent )
int FOOTPRINT_EDITOR_CONTROL::DuplicateFootprint( const TOOL_EVENT& aEvent )
{
LIB_ID fpID = m_frame->GetTreeFPID();
wxString libraryName = fpID.GetLibNickname();
wxString footprintName = fpID.GetLibItemName();
FOOTPRINT* footprint;
if( fpID == m_frame->GetLoadedFPID() )

1
utils/kicad2step/pcb/3d_resolver.cpp
View File

@ -332,7 +332,6 @@ bool S3D_RESOLVER::addPath( const SEARCH_PATH& aPath )
#endif
}
wxString pname = path.GetPath();
std::list< SEARCH_PATH >::iterator sPL = m_Paths.begin();
std::list< SEARCH_PATH >::iterator ePL = m_Paths.end();