haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow no-net teardrops on no-net pads with no-net tracks. 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17566
This commit is contained in:
Jeff Young 2024-03-24 19:14:16 +00:00
parent 2f2c42a06b
commit 50567764b5
1 changed files with 31 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
pcbnew/zone_filler.cpp
View File

@ -885,9 +885,18 @@ void ZONE_FILLER::knockoutThermalReliefs( const ZONE* aZone, PCB_LAYER_ID aLayer
if( !padBBox.Intersects( aZone->GetBoundingBox() ) ) if( !padBBox.Intersects( aZone->GetBoundingBox() ) )
continue; continue;
if( pad->GetNetCode() != aZone->GetNetCode() bool noConnection = pad->GetNetCode() != aZone->GetNetCode();
|| pad->GetNetCode() <= 0
|| pad->GetZoneLayerOverride( aLayer ) == ZLO_FORCE_NO_ZONE_CONNECTION ) if( !aZone->IsTeardropArea() )
{
if( aZone->GetNetCode() == 0
|| pad->GetZoneLayerOverride( aLayer ) == ZLO_FORCE_NO_ZONE_CONNECTION )
{
noConnection = true;
}
}
if( noConnection )
{ {
// collect these for knockout in buildCopperItemClearances() // collect these for knockout in buildCopperItemClearances()
aNoConnectionPads.push_back( pad ); aNoConnectionPads.push_back( pad );
@ -1049,8 +1058,10 @@ void ZONE_FILLER::buildCopperItemClearances( const ZONE* aZone, PCB_LAYER_ID aLa
{ {
if( aTrack->GetBoundingBox().Intersects( zone_boundingbox ) ) if( aTrack->GetBoundingBox().Intersects( zone_boundingbox ) )
{ {
bool sameNet = aTrack->GetNetCode() == aZone->GetNetCode() bool sameNet = aTrack->GetNetCode() == aZone->GetNetCode();
&& aZone->GetNetCode() != 0;
if( !aZone->IsTeardropArea() && aZone->GetNetCode() == 0 )
sameNet = false;
int gap = evalRulesForItems( PHYSICAL_CLEARANCE_CONSTRAINT, int gap = evalRulesForItems( PHYSICAL_CLEARANCE_CONSTRAINT,
aZone, aTrack, aLayer ); aZone, aTrack, aLayer );
@ -1124,8 +1135,15 @@ void ZONE_FILLER::buildCopperItemClearances( const ZONE* aZone, PCB_LAYER_ID aLa
auto knockoutGraphicClearance = auto knockoutGraphicClearance =
[&]( BOARD_ITEM* aItem ) [&]( BOARD_ITEM* aItem )
{ {
int shapeNet = ( aItem->Type() == PCB_SHAPE_T ) ? static_cast<PCB_SHAPE*>( aItem )->GetNetCode() : -1; int shapeNet = -1;
bool sameNet = shapeNet == aZone->GetNetCode() && aZone->GetNetCode() != 0;
if( aItem->Type() == PCB_SHAPE_T )
shapeNet = static_cast<PCB_SHAPE*>( aItem )->GetNetCode();
bool sameNet = shapeNet == aZone->GetNetCode();
if( !aZone->IsTeardropArea() && aZone->GetNetCode() == 0 )
sameNet = false;
// A item on the Edge_Cuts or Margin is always seen as on any layer: // A item on the Edge_Cuts or Margin is always seen as on any layer:
if( aItem->IsOnLayer( aLayer ) if( aItem->IsOnLayer( aLayer )
@ -1174,7 +1192,12 @@ void ZONE_FILLER::buildCopperItemClearances( const ZONE* aZone, PCB_LAYER_ID aLa
{ {
for( PAD* pad : footprint->Pads() ) for( PAD* pad : footprint->Pads() )
{ {
if( pad->GetNetCode() == aZone->GetNetCode() && aZone->GetNetCode() != 0 ) bool sameNet = pad->GetNetCode() == aZone->GetNetCode();
if( !aZone->IsTeardropArea() && aZone->GetNetCode() == 0 )
sameNet = false;
if( sameNet )
{ {
if( pad->IsOnLayer( aLayer ) ) if( pad->IsOnLayer( aLayer ) )
allowedNetTiePads.insert( pad ); allowedNetTiePads.insert( pad );