haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove layer limitations and warnigns now that DRC handles them.

This commit is contained in:
Jeff Young 2018-08-27 14:52:46 +01:00
parent a860a8db54
commit 56de78c130
1 changed files with 8 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
pcbnew/dialogs/dialog_graphic_item_properties.cpp
View File

@ -106,6 +106,14 @@ DIALOG_GRAPHIC_ITEM_PROPERTIES::DIALOG_GRAPHIC_ITEM_PROPERTIES( PCB_BASE_EDIT_FR
m_angleCtrl->SetValidator( m_AngleValidator );
m_AngleValidator.SetWindow( m_angleCtrl );
// Configure the layers list selector
if( m_moduleItem )
m_LayerSelectionCtrl->SetNotAllowedLayerSet( LSET::ForbiddenFootprintLayers() );
m_LayerSelectionCtrl->SetLayersHotkeys( false );
m_LayerSelectionCtrl->SetBoardFrame( m_parent );
m_LayerSelectionCtrl->Resync();
SetInitialFocus( m_startXCtrl );
m_StandardButtonsSizerOK->SetDefault();
@ -205,16 +213,6 @@ bool DIALOG_GRAPHIC_ITEM_PROPERTIES::TransferDataToWindow()
m_thickness.SetValue( m_item->GetWidth() );
// Configure the layers list selector
if( m_moduleItem )
m_LayerSelectionCtrl->SetNotAllowedLayerSet( LSET::InternalCuMask().set( Edge_Cuts ) );
else
m_LayerSelectionCtrl->SetNotAllowedLayerSet( LSET::AllCuMask() );
m_LayerSelectionCtrl->SetLayersHotkeys( false );
m_LayerSelectionCtrl->SetBoardFrame( m_parent );
m_LayerSelectionCtrl->Resync();
if( m_LayerSelectionCtrl->SetLayerSelection( m_item->GetLayer() ) < 0 )
{
wxMessageBox( _( "This item was on a forbidden or non-existing layer.\n"
@ -233,18 +231,6 @@ bool DIALOG_GRAPHIC_ITEM_PROPERTIES::TransferDataFromWindow()
LAYER_NUM layer = m_LayerSelectionCtrl->GetLayerSelection();
if( IsCopperLayer( layer ) )
{
// An graphic item is put on a copper layer.
// This is sometimes useful, for instance for microwave applications and net tees.
// However, because the DRC does not handle graphic items, it can break boards.
// Therefore a confirmation is required.
if( !IsOK( this, _( "The graphic item will be on a copper layer.\n"
"This is very dangerous because DRC does not handle it.\n"
"Are you sure?" ) ) )
return false;
}
BOARD_COMMIT commit( m_parent );
commit.Modify( m_item );