haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QA test( test_prettifier) update golden files and fix a warning message.

This commit is contained in:
jean-pierre charras 2024-01-01 10:57:32 +01:00
parent 8373786e40
commit 58b7eda47a
3 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qa/data/pcbnew/prettifier/Reverb_BTDR-1V_formatted.kicad_mod
View File

@ -1,5 +1,5 @@
(footprint "Reverb_BTDR-1V" (footprint "Reverb_BTDR-1V"
(version 20231212) (version 20231231)
(generator "pcbnew") (generator "pcbnew")
(generator_version "7.99") (generator_version "7.99")
(layer "F.Cu") (layer "F.Cu")

2
qa/data/pcbnew/prettifier/Samtec_HLE-133-02-xx-DV-PE-LC_2x33_P2.54mm_Horizontal_formatted.kicad_mod
View File

@ -1,5 +1,5 @@
(footprint "Samtec_HLE-133-02-xx-DV-PE-LC_2x33_P2.54mm_Horizontal" (footprint "Samtec_HLE-133-02-xx-DV-PE-LC_2x33_P2.54mm_Horizontal"
(version 20231212) (version 20231231)
(generator "pcbnew") (generator "pcbnew")
(generator_version "7.99") (generator_version "7.99")
(layer "F.Cu") (layer "F.Cu")

17
qa/tests/pcbnew/test_prettifier.cpp
View File

@ -1,7 +1,7 @@
/* /*
* This program source code file is part of KiCad, a free EDA CAD application. * This program source code file is part of KiCad, a free EDA CAD application.
* *
* Copyright (C) 2023 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2024 KiCad Developers, see AUTHORS.txt for contributors.
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -53,7 +53,7 @@ BOOST_FIXTURE_TEST_CASE( FootprintPrettifier, PRETTIFIER_TEST_FIXTURE )
"Samtec_HLE-133-02-xx-DV-PE-LC_2x33_P2.54mm_Horizontal" "Samtec_HLE-133-02-xx-DV-PE-LC_2x33_P2.54mm_Horizontal"
}; };
std::unique_ptr<FOOTPRINT> original, converted; std::unique_ptr<FOOTPRINT> original, converted, golden;
PCB_IO_KICAD_SEXPR plugin; PCB_IO_KICAD_SEXPR plugin;
std::string tempLibPath = fmt::format( "{}/prettifier.pretty", std::string tempLibPath = fmt::format( "{}/prettifier.pretty",
@ -91,17 +91,20 @@ BOOST_FIXTURE_TEST_CASE( FootprintPrettifier, PRETTIFIER_TEST_FIXTURE )
std::string goldenPath = fmt::format( "{}prettifier/{}_formatted.kicad_mod", std::string goldenPath = fmt::format( "{}prettifier/{}_formatted.kicad_mod",
KI_TEST::GetPcbnewTestDataDir(), KI_TEST::GetPcbnewTestDataDir(),
footprint.ToStdString() ); footprint.ToStdString() );
{
// Note also m_fileFormatVersionAtLoad could create an issue // Note also m_fileFormatVersionAtLoad (of gloden file) could create an issue
// So warn the user if happens // during comprarison, so warn the user if happens
if( converted->GetFileFormatVersionAtLoad() != original->GetFileFormatVersionAtLoad() ) BOOST_CHECK_NO_THROW( golden = KI_TEST::ReadFootprintFromFileOrStream( goldenPath ) );
BOOST_REQUIRE( golden.get() );
if( converted->GetFileFormatVersionAtLoad() != golden->GetFileFormatVersionAtLoad() )
{ {
wxLogWarning( "Golden file %s has a old version id %d and need update (now %d)", wxLogWarning( "Golden file %s has a old version id %d and need update (now %d)",
goldenPath.c_str(), goldenPath.c_str(),
original->GetFileFormatVersionAtLoad(),converted->GetFileFormatVersionAtLoad() ); golden->GetFileFormatVersionAtLoad(),converted->GetFileFormatVersionAtLoad() );
} }
{
std::ifstream test( newPath ); std::ifstream test( newPath );
std::ifstream golden( goldenPath ); std::ifstream golden( goldenPath );