haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Holes need a parent. 

SetHole() handles all this for us.  Make sure it's called.

Fixes https://gitlab.com/kicad/code/kicad/issues/14702
This commit is contained in:
Jeff Young 2023-05-08 11:35:41 +01:00
parent f883b7fd4d
commit 5b3798a370
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pcbnew/router/pns_solid.h
View File

@ -2,7 +2,7 @@
* KiRouter - a push-and-(sometimes-)shove PCB router * KiRouter - a push-and-(sometimes-)shove PCB router
* *
* Copyright (C) 2013 CERN * Copyright (C) 2013 CERN
* Copyright (C) 2016-2021 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2016-2023 KiCad Developers, see AUTHORS.txt for contributors.
* Author: Tomasz Wlostowski <tomasz.wlostowski@cern.ch> * Author: Tomasz Wlostowski <tomasz.wlostowski@cern.ch>
* *
* This program is free software: you can redistribute it and/or modify it * This program is free software: you can redistribute it and/or modify it
@ -36,9 +36,9 @@ class SOLID : public ITEM
{ {
public: public:
SOLID() : SOLID() :
ITEM( SOLID_T ), ITEM( SOLID_T ),
m_shape( nullptr ), m_shape( nullptr ),
m_hole( nullptr ) m_hole( nullptr )
{ {
m_movable = false; m_movable = false;
m_padToDie = 0; m_padToDie = 0;
@ -46,24 +46,20 @@ public:
~SOLID() ~SOLID()
{ {
if ( m_hole ) delete m_hole;
delete m_hole;
delete m_shape; delete m_shape;
} }
SOLID( const SOLID& aSolid ) : SOLID( const SOLID& aSolid ) :
ITEM( aSolid ) ITEM( aSolid ),
m_shape( nullptr ),
m_hole( nullptr )
{ {
if( aSolid.m_shape ) if( aSolid.m_shape )
m_shape = aSolid.m_shape->Clone(); SetShape( aSolid.m_shape->Clone() );
else
m_shape = nullptr;
if( aSolid.m_hole ) if( aSolid.m_hole )
m_hole = aSolid.m_hole->Clone(); SetHole( aSolid.m_hole->Clone() );
else
m_hole = nullptr;
m_pos = aSolid.m_pos; m_pos = aSolid.m_pos;
m_padToDie = aSolid.m_padToDie; m_padToDie = aSolid.m_padToDie;