observable can live in core

common/CMakeLists.txt

@@ -369,7 +369,6 @@ set( COMMON_SRCS
     markup_parser.cpp
     netclass.cpp
     notifications_manager.cpp
-    observable.cpp
     origin_transforms.cpp
     page_info.cpp
     paths.cpp

include/gal/gal_display_options.h

@@ -25,7 +25,7 @@
 #define GAL_DISPLAY_OPTIONS_H__
 
 #include <gal/dpi_scaling.h>
-#include <observable.h>
+#include <core/observable.h>
 
 class COMMON_SETTINGS;
 struct WINDOW_SETTINGS;

libs/core/CMakeLists.txt

@@ -6,6 +6,7 @@ endif()
 
 
 add_library( core STATIC
+    observable.cpp
     thread_pool.cpp
     version_compare.cpp
     wx_stl_compat.cpp

libs/core/include/core/observable.h

@@ -241,7 +241,6 @@ public:
                 throw;
             }
 
-            leave_iteration();
         }
     }
 };

libs/core/observable.cpp

@@ -21,7 +21,7 @@
 * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 */
 
-#include "observable.h"
+#include <core/observable.h>
 #include <algorithm>
 
 namespace UTIL {

qa/tools/common_tools/CMakeLists.txt

@@ -26,9 +26,6 @@ add_executable( qa_common_tools
     # # stuff from common due to...units?
     # ../../common/eda_text.cpp
 
-    # stuff from common which is needed...why?
-    ${CMAKE_SOURCE_DIR}/common/observable.cpp
-
     # Mock Pgm needed for advanced_config in coroutines
     ${CMAKE_SOURCE_DIR}/qa/mocks/kicad/common_mocks.cpp
 
@@ -51,6 +48,7 @@ include_directories(
 
 target_link_libraries( qa_common_tools
     common
+    core
     libcontext
     gal
     qa_utils