pcbnew: Cleanup includes of pcbnew_id.h

* Remove unused IDs from the enum
* Remove the include statements from files that no longer need it

common/tool/tool_dispatcher.cpp

@@ -34,7 +34,6 @@
 
 #include <class_draw_panel_gal.h>
 #include <eda_draw_frame.h>
-#include <pcbnew_id.h>
 
 #include <core/optional.h>
 

pcbnew/autorouter/autoplacer_tool.cpp

@@ -32,9 +32,6 @@
 #include <view/view.h>
 #include <view/view_controls.h>
 
-// For frame ToolID values
-#include <pcbnew_id.h>
-
 // For action icons
 #include <bitmaps.h>
 

pcbnew/cross-probing.cpp

@@ -38,7 +38,6 @@
 #include <pcb_edit_frame.h>
 #include <eda_dde.h>
 #include <macros.h>
-#include <pcbnew_id.h>
 #include <class_board.h>
 #include <class_module.h>
 #include <class_track.h>

pcbnew/dialogs/dialog_find.cpp

@@ -34,7 +34,6 @@
 #include <kicad_string.h>
 #include <pcb_edit_frame.h>
 #include <pcbnew.h>
-#include <pcbnew_id.h>
 #include <string>
 #include <tool/tool_manager.h>
 #include <tools/pcb_actions.h>

pcbnew/dialogs/dialog_set_grid.cpp

@@ -28,7 +28,7 @@
 #include <pcb_base_edit_frame.h>
 #include <tools/pcb_actions.h>
 #include <tool/tool_manager.h>
-#include <pcbnew_id.h>
+#include <id.h>
 #include <tool/common_tools.h>
 
 // Max values for grid size

pcbnew/dialogs/panel_pcbnew_display_options.cpp

@@ -23,7 +23,6 @@
 #include <pcb_edit_frame.h>
 #include <pcb_display_options.h>
 #include <config_map.h>
-#include <pcbnew_id.h>
 #include <panel_pcbnew_display_options.h>
 #include <pcb_draw_panel_gal.h>
 #include <pcb_view.h>

pcbnew/dialogs/panel_pcbnew_settings.cpp

@@ -26,7 +26,6 @@
 #include <pcbnew.h>
 #include <pcb_edit_frame.h>
 #include <board_design_settings.h>
-#include <pcbnew_id.h>
 #include <class_board.h>
 #include <panel_pcbnew_settings.h>
 #include <widgets/paged_dialog.h>

pcbnew/footprint_editor_options.cpp

@@ -29,7 +29,6 @@
 #include <footprint_edit_frame.h>
 #include <board_design_settings.h>
 #include <layers_id_colors_and_visibility.h>
-#include <pcbnew_id.h>
 
 
 PARAM_CFG_ARRAY& FOOTPRINT_EDIT_FRAME::GetConfigurationSettings()

pcbnew/footprint_preview_panel.cpp

@@ -37,7 +37,7 @@
 #include <wx/stattext.h>
 #include <pgm_base.h>
 #include <painter.h>
-#include <pcbnew_id.h>
+#include <id.h>
 
 /**
  * Threadsafe interface class between loader thread and panel class.

pcbnew/footprint_tree_pane.cpp

@@ -24,7 +24,6 @@
 #include "footprint_tree_pane.h"
 #include "fp_tree_synchronizing_adapter.h"
 #include <widgets/lib_tree.h>
-#include <pcbnew_id.h>
 #include <footprint_edit_frame.h>
 #include <fp_lib_table.h>
 
@@ -41,7 +40,7 @@ FOOTPRINT_TREE_PANE::FOOTPRINT_TREE_PANE( FOOTPRINT_EDIT_FRAME* aParent )
     SetSizer( boxSizer );      // should remove the previous sizer according to wxWidgets docs
     Layout();
     boxSizer->Fit( this );
-    
+
     // Event handlers
     Bind( COMPONENT_SELECTED, &FOOTPRINT_TREE_PANE::onComponentSelected, this );
     m_tree->Bind( wxEVT_UPDATE_UI, &FOOTPRINT_TREE_PANE::onUpdateUI, this );

pcbnew/load_select_footprint.cpp

@@ -85,7 +85,6 @@ static void clearModuleItemFlags( BOARD_ITEM* aItem )
     aItem->ClearFlags();
 }
 
-#include "pcbnew_id.h"
 #include <bitmaps.h>
 bool FOOTPRINT_EDIT_FRAME::Load_Module_From_BOARD( MODULE* aModule )
 {

pcbnew/pad_print_functions.cpp

@@ -35,7 +35,6 @@
 #include <pcb_edit_frame.h>
 #include <pcb_screen.h>
 #include <pcbnew.h>
-#include <pcbnew_id.h> // ID_TRACK_BUTT
 #include <trigo.h>
 
 

pcbnew/pcb_screen.cpp

@@ -36,7 +36,7 @@
 #include <board_design_settings.h>
 #include <layers_id_colors_and_visibility.h>
 
-#include <pcbnew_id.h>
+#include <id.h>
 
 
 #define ZOOM_FACTOR( x )       ( x * IU_PER_MILS / 10 )

pcbnew/pcbnew_config.cpp

@@ -43,7 +43,6 @@
 #include <class_board.h>
 #include <class_module.h>
 #include <pcbplot.h>
-#include <pcbnew_id.h>
 #include <footprint_viewer_frame.h>
 #include <invoke_pcb_dialog.h>
 #include <wildcards_and_files_ext.h>

pcbnew/pcbnew_id.h

@@ -18,26 +18,6 @@ enum pcbnew_ids
     ID_COPY_BOARD_AS,
     ID_IMPORT_NON_KICAD_BOARD,
 
-    // Right vertical tool bar command IDs.
-    ID_PCB_HIGHLIGHT_BUTT,
-    ID_LOCAL_RATSNEST_BUTT,
-    ID_PCB_MODULE_BUTT,
-    ID_TRACK_BUTT,
-    ID_PCB_ZONES_BUTT,
-    ID_PCB_DRAW_VIA_BUTT,
-    ID_PCB_KEEPOUT_BUTT,
-    ID_PCB_ADD_LINE_BUTT,
-    ID_PCB_ADD_POLYGON_BUTT,
-    ID_PCB_CIRCLE_BUTT,
-    ID_PCB_ARC_BUTT,
-    ID_PCB_ADD_TEXT_BUTT,
-    ID_PCB_DIMENSION_BUTT,
-    ID_PCB_TARGET_BUTT,
-    ID_PCB_DELETE_ITEM_BUTT,
-    ID_PCB_PLACE_OFFSET_COORD_BUTT,
-    ID_PCB_PLACE_GRID_COORD_BUTT,
-    ID_PCB_MEASUREMENT_TOOL,
-
     // Tracks and vias sizes general options
     ID_AUX_TOOLBAR_PCB_VIA_SIZE,
     ID_AUX_TOOLBAR_PCB_TRACK_WIDTH,
@@ -113,8 +93,6 @@ enum pcbnew_ids
     ID_TOOLBARH_PCB_ACTION_PLUGIN,
     ID_TOOLBARH_PCB_ACTION_PLUGIN_REFRESH,
 
-    ID_AUX_TOOLBAR_PCB_SELECT_LAYER_PAIR,
-
     ID_PCB_GEN_CMP_FILE,
     ID_PCB_GEN_BOM_FILE_FROM_BOARD,
     ID_PCB_3DSHAPELIB_WIZARD,

pcbnew/router/pns_tool_base.cpp

@@ -30,7 +30,6 @@ using namespace std::placeholders;
 #include <pcb_edit_frame.h>
 #include <id.h>
 #include <macros.h>
-#include <pcbnew_id.h>
 #include <view/view_controls.h>
 #include <pcb_painter.h>
 #include <dialogs/dialog_pns_settings.h>

pcbnew/swig/pcbnew_scripting_helpers.cpp

@@ -39,7 +39,6 @@
 #include <macros.h>
 #include <pcb_draw_panel_gal.h>
 #include <pcbnew.h>
-#include <pcbnew_id.h>
 #include <pcbnew_scripting_helpers.h>
 
 static PCB_EDIT_FRAME* s_PcbEditFrame = NULL;

pcbnew/tools/edit_tool.cpp

@@ -33,7 +33,6 @@
 #include <kiway.h>
 #include <footprint_edit_frame.h>
 #include <array_creator.h>
-#include <pcbnew_id.h>
 #include <status_popup.h>
 #include <tool/tool_manager.h>
 #include <tools/pcb_actions.h>

pcbnew/tools/microwave_tool.cpp

@@ -31,7 +31,6 @@
 #include <confirm.h>
 #include <preview_items/two_point_geom_manager.h>
 #include <preview_items/centreline_rect_item.h>
-#include <pcbnew_id.h>
 #include <bitmaps.h>
 #include <class_board_item.h>
 #include <class_module.h>

pcbnew/tools/pad_tool.cpp

@@ -37,7 +37,6 @@
 #include <tools/pcb_selection_conditions.h>
 #include <tools/edit_tool.h>
 #include <dialogs/dialog_enum_pads.h>
-#include "pcbnew_id.h"
 
 
 PAD_TOOL::PAD_TOOL() :

pcbnew/tools/pcbnew_control.cpp

@@ -48,7 +48,6 @@
 #include <pcb_edit_frame.h>
 #include <pcb_painter.h>
 #include <pcb_screen.h>
-#include <pcbnew_id.h>
 #include <properties.h>
 #include <tool/tool_manager.h>
 #include <view/view_controls.h>

pcbnew/zones_by_polygon.cpp

@@ -34,7 +34,6 @@
 #include <class_zone.h>
 #include <pcbnew.h>
 #include <zones.h>
-#include <pcbnew_id.h>
 #include <zones_functions_for_undo_redo.h>
 #include <tools/drc.h>
 #include <connectivity/connectivity_data.h>