haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

LENGTH_TUNER_TOOL: fix a bug (missing initialization) creating a serious isse. 

m_inLengthTuner was not initialized, preventing the tool to be started (sometimes)
Fix also a few not initialized members.
This commit is contained in:
jean-pierre charras 2023-08-06 13:20:43 +02:00
parent 4c4bbdc8f3
commit 5e04e90fb3
4 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
common/jobs/job_export_pcb_pdf.h
View File

@ -39,7 +39,8 @@ public:
m_plotFootprintValues( true ),
m_plotRefDes( true ),
m_plotBorderTitleBlocks( false ),
m_printMaskLayer()
m_printMaskLayer(),
m_drillShapeOption( 2 )
{
}

14
common/jobs/job_export_pcb_svg.h
View File

@ -29,9 +29,17 @@ class JOB_EXPORT_PCB_SVG : public JOB
{
public:
JOB_EXPORT_PCB_SVG( bool aIsCli ) :
JOB( "svg", aIsCli ), m_filename(), m_outputFile(), m_colorTheme(), m_mirror( false ),
m_blackAndWhite( false ), m_negative( false ), m_plotDrawingSheet( true ),
m_pageSizeMode( 0 ), m_printMaskLayer()
JOB( "svg", aIsCli ),
m_filename(),
m_outputFile(),
m_colorTheme(),
m_mirror( false ),
m_blackAndWhite( false ),
m_negative( false ),
m_plotDrawingSheet( true ),
m_pageSizeMode( 0 ),
m_printMaskLayer(),
m_drillShapeOption( 2 )
{
}

3
common/notifications_manager.cpp
View File

@ -322,7 +322,8 @@ void NOTIFICATIONS_MANAGER::Create( const wxString& aKey,
}
else
{
m_notifications.emplace_back( NOTIFICATION{ aTitle, aDescription, aHref, aKey } );
m_notifications.emplace_back( NOTIFICATION{ aTitle, aDescription, aHref,
aKey, wxEmptyString } );
}
if( m_shownDialogs.size() > 0 )

3
pcbnew/router/length_tuner_tool.cpp
View File

@ -85,6 +85,7 @@ LENGTH_TUNER_TOOL::LENGTH_TUNER_TOOL() :
// set the initial tune mode for the settings dialog,
// in case the dialog is opened before the tool is activated the first time
m_lastTuneMode = PNS::ROUTER_MODE::PNS_MODE_TUNE_SINGLE;
m_inLengthTuner = false;
}
@ -95,6 +96,8 @@ LENGTH_TUNER_TOOL::~LENGTH_TUNER_TOOL()
bool LENGTH_TUNER_TOOL::Init()
{
m_inLengthTuner = false;
auto& menu = m_menu.GetMenu();
menu.SetTitle( _( "Length Tuner" ) );