haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PCB: always parse ki_fp_filters as a property, not a field

This commit is contained in:
Mike Williams 2024-02-19 09:41:27 -05:00
parent 27911d9b5a
commit 60fe87a73c
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pcbnew/pcb_io/kicad_sexpr/pcb_io_kicad_sexpr_parser.cpp
View File

@ -4072,13 +4072,6 @@ FOOTPRINT* PCB_IO_KICAD_SEXPR_PARSER::parseFOOTPRINT_unchecked( wxArrayString* a
break;
}
if( pName == "ki_fp_filters" )
{
footprint->SetFilters( pValue );
NeedRIGHT();
break;
}
// Sheet file and name used to be stored as properties invisible to the user
if( pName == "Sheetfile" || pName == "Sheet file" )
{
@ -4095,6 +4088,21 @@ FOOTPRINT* PCB_IO_KICAD_SEXPR_PARSER::parseFOOTPRINT_unchecked( wxArrayString* a
}
}
// 8.0.0rc3 had a bug where these properties were mistakenly added to the footprint as fields,
// this will remove them as fields but still correctly set the footprint filters
if( pName == "ki_fp_filters" )
{
footprint->SetFilters( pValue );
// Use the text effect parsing function because it will handle ki_fp_filters as a property
// with no text effects, but will also handle parsing the text effects. We just drop the effects
// if they're present.
PCB_FIELD ignored = PCB_FIELD( footprint.get(), footprint->GetFieldCount(), pName );
parsePCB_TEXT_effects( &ignored );
break;
}
PCB_FIELD* field = nullptr;
if( footprint->HasFieldByName( pName ) )