haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix shadowed definition of EAGLE constant

This commit is contained in:
Ian McInerney 2022-09-24 00:08:32 +01:00
parent 31498673b7
commit 6310f84a57
3 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/eda_tools.cpp
View File

@ -34,7 +34,7 @@ bool IsFileFromEDATool( const wxFileName& aFileName, const EDA_TOOLS aTool )
{ {
switch( aTool ) switch( aTool )
{ {
case EAGLE: case EDA_TOOLS::EAGLE:
if( textFile.GetLineCount() > 2 if( textFile.GetLineCount() > 2
&& textFile[1].StartsWith( wxT( "<!DOCTYPE eagle SYSTEM" ) ) && textFile[1].StartsWith( wxT( "<!DOCTYPE eagle SYSTEM" ) )
&& textFile[2].StartsWith( wxT( "<eagle version" ) ) ) && textFile[2].StartsWith( wxT( "<eagle version" ) ) )

2
include/eda_tools.h
View File

@ -37,7 +37,7 @@
/** /**
* Enumeration of tools * Enumeration of tools
*/ */
enum EDA_TOOLS enum class EDA_TOOLS
{ {
EAGLE EAGLE
}; };

7
kicad/tools/kicad_manager_control.cpp
View File

@ -359,7 +359,7 @@ int KICAD_MANAGER_CONTROL::ImportNonKicadProj( const TOOL_EVENT& aEvent )
{ {
// Check if droppedFile is an eagle file. // Check if droppedFile is an eagle file.
// If not, return and do not import files. // If not, return and do not import files.
if( !IsFileFromEDATool( droppedFileName, EAGLE ) ) if( !IsFileFromEDATool( droppedFileName, EDA_TOOLS::EAGLE ) )
return -1; return -1;
schFileExtension = EagleSchematicFileExtension; schFileExtension = EagleSchematicFileExtension;
@ -367,10 +367,8 @@ int KICAD_MANAGER_CONTROL::ImportNonKicadProj( const TOOL_EVENT& aEvent )
schFileType = SCH_IO_MGR::SCH_EAGLE; schFileType = SCH_IO_MGR::SCH_EAGLE;
pcbFileType = IO_MGR::EAGLE; pcbFileType = IO_MGR::EAGLE;
} }
else
{
// Cadstar project. // Cadstar project.
if( droppedFileName.GetExt() == CadstarSchematicFileExtension else if( droppedFileName.GetExt() == CadstarSchematicFileExtension
|| droppedFileName.GetExt() == CadstarPcbFileExtension ) || droppedFileName.GetExt() == CadstarPcbFileExtension )
{ {
schFileExtension = CadstarSchematicFileExtension; schFileExtension = CadstarSchematicFileExtension;
@ -379,6 +377,7 @@ int KICAD_MANAGER_CONTROL::ImportNonKicadProj( const TOOL_EVENT& aEvent )
pcbFileType = IO_MGR::CADSTAR_PCB_ARCHIVE; pcbFileType = IO_MGR::CADSTAR_PCB_ARCHIVE;
} }
else else
{
return -1; return -1;
} }