haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coverity fixes.

This commit is contained in:
Jeff Young 2022-08-22 17:52:42 +01:00
parent f42b66bc1c
commit 638198251a
5 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
eeschema/bus_alias.h
View File

@ -33,7 +33,8 @@ class SCH_SCREEN;
class BUS_ALIAS class BUS_ALIAS
{ {
public: public:
BUS_ALIAS( SCH_SCREEN* aParent = nullptr ) BUS_ALIAS( SCH_SCREEN* aParent = nullptr ) :
m_parent( aParent )
{ } { }
~BUS_ALIAS() ~BUS_ALIAS()

4
eeschema/dialogs/panel_setup_buses.cpp
View File

@ -27,7 +27,9 @@
PANEL_SETUP_BUSES::PANEL_SETUP_BUSES( wxWindow* aWindow, SCH_EDIT_FRAME* aFrame ) : PANEL_SETUP_BUSES::PANEL_SETUP_BUSES( wxWindow* aWindow, SCH_EDIT_FRAME* aFrame ) :
PANEL_SETUP_BUSES_BASE( aWindow ), PANEL_SETUP_BUSES_BASE( aWindow ),
m_frame( aFrame ) m_frame( aFrame ),
m_errorGrid( nullptr ),
m_errorRow( -1 )
{ {
m_membersLabelTemplate = m_membersLabel->GetLabel(); m_membersLabelTemplate = m_membersLabel->GetLabel();

2
eeschema/sch_plugins/cadstar/cadstar_sch_archive_loader.cpp
View File

@ -917,7 +917,7 @@ void CADSTAR_SCH_ARCHIVE_LOADER::loadNets()
BUS bus = Schematic.Buses.at( busTerm.BusID ); BUS bus = Schematic.Buses.at( busTerm.BusID );
if( !alg::contains( m_busesMap.at( bus.ID )->Members(), netName ) ) if( !alg::contains( m_busesMap.at( bus.ID )->Members(), netName ) )
m_busesMap.at( bus.ID )->Members().push_back( netName ); m_busesMap.at( bus.ID )->Members().emplace_back( netName );
SCH_BUS_WIRE_ENTRY* busEntry = SCH_BUS_WIRE_ENTRY* busEntry =
new SCH_BUS_WIRE_ENTRY( getKiCadPoint( busTerm.FirstPoint ), false ); new SCH_BUS_WIRE_ENTRY( getKiCadPoint( busTerm.FirstPoint ), false );

2
eeschema/sch_plugins/kicad/sch_sexpr_parser.cpp
View File

@ -3716,7 +3716,7 @@ void SCH_SEXPR_PARSER::parseBusAlias( SCH_SCREEN* aScreen )
if( m_requiredVersion < 20210621 ) if( m_requiredVersion < 20210621 )
member = ConvertToNewOverbarNotation( member ); member = ConvertToNewOverbarNotation( member );
busAlias->Members().push_back( member ); busAlias->Members().emplace_back( member );
token = NextTok(); token = NextTok();
} }

4
eeschema/sch_plugins/legacy/sch_legacy_plugin.cpp
View File

@ -1375,8 +1375,8 @@ std::shared_ptr<BUS_ALIAS> SCH_LEGACY_PLUGIN::loadBusAlias( LINE_READER& aReader
buf.clear(); buf.clear();
parseUnquotedString( buf, aReader, line, &line, true ); parseUnquotedString( buf, aReader, line, &line, true );
if( buf.Len() > 0 ) if( !buf.IsEmpty() )
busAlias->Members().push_back( buf ); busAlias->Members().emplace_back( buf );
} }
return busAlias; return busAlias;