Low hanging fruit to kicommon

common/CMakeLists.txt

@@ -43,6 +43,9 @@ add_library( singletop STATIC EXCLUDE_FROM_ALL
 # Functions and data all need to use the #include <import_export.h> and be declared
 # as APIEXPORT
 set( KICOMMON_SRCS
+    asset_archive.cpp
+    array_axis.cpp
+    array_options.cpp
     exceptions.cpp
     lib_id.cpp
     locale_io.cpp
@@ -351,9 +354,6 @@ set( COMMON_SRCS
     ${COMMON_IMPORT_GFX_SRCS}
     jobs/job_dispatcher.cpp
     advanced_config.cpp
-    array_axis.cpp
-    array_options.cpp
-    asset_archive.cpp
     background_jobs_monitor.cpp
     base_screen.cpp
     bin_mod.cpp

include/array_axis.h

@@ -24,6 +24,7 @@
 #ifndef ARRAY_AXIS__H
 #define ARRAY_AXIS__H
 
+#include <kicommon.h>
 #include <optional>
 
 #include <wx/string.h>
@@ -35,7 +36,7 @@
  * For example, a rectangular grid has two axes, X and Y, but a circular array
  * has only one, that runs around the circle.
  */
-class ARRAY_AXIS
+class KICOMMON_API ARRAY_AXIS
 {
 public:
     enum NUMBERING_TYPE

include/array_options.h

@@ -24,6 +24,7 @@
 #ifndef PCBNEW_ARRAY_OPTIONS__H
 #define PCBNEW_ARRAY_OPTIONS__H
 
+#include <kicommon.h>
 #include <math/vector2d.h>
 #include <array_axis.h>
 #include <geometry/eda_angle.h>
@@ -33,7 +34,7 @@
  * The base #ARRAY_OPTIONS do not encode a specific geometry or numbering
  * method, this is done by derived classes.
  */
-class ARRAY_OPTIONS
+class KICOMMON_API ARRAY_OPTIONS
 {
 public:
     enum ARRAY_TYPE_T
@@ -140,7 +141,7 @@ protected:
 };
 
 
-struct ARRAY_GRID_OPTIONS : public ARRAY_OPTIONS
+struct KICOMMON_API ARRAY_GRID_OPTIONS : public ARRAY_OPTIONS
 {
     ARRAY_GRID_OPTIONS()
             : ARRAY_OPTIONS( ARRAY_GRID ),
@@ -172,7 +173,7 @@ private:
 };
 
 
-struct ARRAY_CIRCULAR_OPTIONS : public ARRAY_OPTIONS
+struct KICOMMON_API ARRAY_CIRCULAR_OPTIONS : public ARRAY_OPTIONS
 {
     ARRAY_CIRCULAR_OPTIONS()
             : ARRAY_OPTIONS( ARRAY_CIRCULAR ),

include/asset_archive.h

@@ -20,6 +20,7 @@
 #ifndef KICAD_ASSET_ARCHIVE_H
 #define KICAD_ASSET_ARCHIVE_H
 
+#include <kicommon.h>
 #include <unordered_map>
 #include <vector>
 
@@ -32,7 +33,7 @@
  * The entire contents of the archive will be uncompressed and kept resident in memory in the
  * current implementation, so consider this before reusing this as-is for new use cases.
  */
-class ASSET_ARCHIVE
+class KICOMMON_API ASSET_ARCHIVE
 {
 public:
     ASSET_ARCHIVE( const wxString& aFilePath, bool aLoadNow = true );