haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

WX_GRID::EnsureColLabelsVisible(): avoid updating column label size when not needed. 

Updating column label size generates a UI event and if EnsureColLabelsVisible()
is called inside a UI event, this is a bit annoying.
This commit is contained in:
jean-pierre charras 2021-09-14 20:08:48 +02:00
parent 3b121359ae
commit 666f7ea38c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/widgets/wx_grid.cpp
View File

@ -295,6 +295,7 @@ void WX_GRID::EnsureColLabelsVisible()
// TODO: use a better way to evaluate the text size, for bold font // TODO: use a better way to evaluate the text size, for bold font
int line_height = int( GetTextExtent( "Mj" ).y * 1.1 ) + 3; int line_height = int( GetTextExtent( "Mj" ).y * 1.1 ) + 3;
int row_height = GetColLabelSize(); int row_height = GetColLabelSize();
int initial_row_height = row_height;
// Headers can be multiline. Fix the Column Label Height to show the full header // Headers can be multiline. Fix the Column Label Height to show the full header
// However GetTextExtent does not work on multiline strings, // However GetTextExtent does not work on multiline strings,
@ -311,5 +312,8 @@ void WX_GRID::EnsureColLabelsVisible()
} }
} }
SetColLabelSize( row_height ); // Update the column label size, but only if needed, to avoid generating useless
// and perhaps annoying UI events when the size does not change
if( initial_row_height != row_height )
SetColLabelSize( row_height );
} }