haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Better comments in files related to my previous commit.

This commit is contained in:
jean-pierre charras 2021-01-01 17:08:17 +01:00
parent 93e186f53e
commit 6a81113c2d
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eeschema/symbol_tree_model_adapter.cpp
View File

@ -85,10 +85,11 @@ void SYMBOL_TREE_MODEL_ADAPTER::AddLibraries( const std::vector<wxString>& aNick
if( prg )
{
// Force immediate deletion of the WX_PROGRESS_REPORTER (do not use Destroy() )
// Force immediate deletion of the APP_PROGRESS_DIALOG
// ( do not use Destroy(), or use Destroy() followed by wxSafeYield() )
// because on Windows, APP_PROGRESS_DIALOG has some side effects on the event loop
// manager. A side effect is the call of ShowModal() of a dialog following
// the use of SYMBOL_TREE_MODEL_ADAPTER creating a SYMBOL_TREE_MODEL_ADAPTER
// the use of SYMBOL_TREE_MODEL_ADAPTER creating a APP_PROGRESS_DIALOG
// has a broken behavior (incorrect modal behavior).
delete prg;
m_show_progress = false;

10
pcbnew/load_select_footprint.cpp
View File

@ -212,10 +212,12 @@ FOOTPRINT* PCB_BASE_FRAME::SelectFootprintFromLibTree( LIB_ID aPreselect )
_( "Loading Footprint Libraries" ), 3 );
GFootprintList.ReadFootprintFiles( fpTable, nullptr, progressReporter );
bool cancel = progressReporter->WasCancelled();
// Force immediate deletion of the WX_PROGRESS_REPORTER (do not use Destroy() )
// because on Windows, APP_PROGRESS_DIALOG has some side effects on the event loop
// manager. A side effect is the call of ShowModal() of a dialog following
// the use of SYMBOL_TREE_MODEL_ADAPTER creating a SYMBOL_TREE_MODEL_ADAPTER
// Force immediate deletion of the WX_PROGRESS_REPORTER
// ( do not use Destroy(), or use Destroy() followed by wxSafeYield() )
// because on Windows, APP_PROGRESS_DIALOG or WX_PROGRESS_REPORTER has some side
// effects on the event loop manager.
// A side effect is the call of ShowModal() or ShowQuasiModal() of a dialog following
// the use of a WX_PROGRESS_REPORTER
// has a broken behavior (incorrect modal or quasi modal behavior).
delete progressReporter;