haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coverity fixes 

Uninitialized variables: CID #163188 and #174187
Unused variable: CID #168698
This commit is contained in:
Maciej Suminski 2018-02-20 09:14:51 +01:00
parent 7e0ff6fe8d
commit 6c1a05a7d5
3 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
include/geometry/shape_arc.h
View File

@ -38,9 +38,10 @@ public:
SHAPE_ARC( const VECTOR2I& aArcCenter, const VECTOR2I& aArcStartPoint, SHAPE_ARC( const VECTOR2I& aArcCenter, const VECTOR2I& aArcStartPoint,
double aCenterAngle, int aWidth = 0 ) : double aCenterAngle, int aWidth = 0 ) :
SHAPE( SH_ARC ), m_p0( aArcStartPoint ), m_pc( aArcCenter ), m_centralAngle( aCenterAngle ) SHAPE( SH_ARC ), m_p0( aArcStartPoint ), m_pc( aArcCenter ), m_centralAngle( aCenterAngle ),
{ m_width( aWidth )
}; {
}
SHAPE_ARC( const SHAPE_ARC& aOther ) SHAPE_ARC( const SHAPE_ARC& aOther )
: SHAPE( SH_ARC ) : SHAPE( SH_ARC )
@ -51,7 +52,7 @@ public:
m_width = aOther.m_width; m_width = aOther.m_width;
} }
~SHAPE_ARC() {}; ~SHAPE_ARC() {}
SHAPE* Clone() const override SHAPE* Clone() const override
{ {
@ -68,8 +69,8 @@ public:
return BOX2I(); // fixme return BOX2I(); // fixme
} }
bool Collide( const SEG& aSeg, int aClearance = 0 ) const override; bool Collide( const SEG& aSeg, int aClearance = 0 ) const override;
bool Collide( const VECTOR2I& aP, int aClearance = 0 ) const override; bool Collide( const VECTOR2I& aP, int aClearance = 0 ) const override;
void SetWidth( int aWidth ) void SetWidth( int aWidth )
{ {

4
pcbnew/footprint_info_impl.cpp
View File

@ -306,7 +306,9 @@ size_t FOOTPRINT_LIST_IMPL::CountFinished()
FOOTPRINT_LIST_IMPL::FOOTPRINT_LIST_IMPL() : FOOTPRINT_LIST_IMPL::FOOTPRINT_LIST_IMPL() :
m_loader( nullptr ), m_loader( nullptr ),
m_count_finished( 0 ), m_count_finished( 0 ),
m_progress_reporter( nullptr ) m_libraries_last_mod_checksum( 0 ),
m_progress_reporter( nullptr ),
m_cancelled( false )
{ {
} }

2
pcbnew/pad_draw_functions.cpp
View File

@ -535,8 +535,6 @@ void D_PAD::DrawShape( EDA_RECT* aClipBox, wxDC* aDC, PAD_DRAWINFO& aDrawInfo )
SHAPE_POLY_SET clearance_outline; SHAPE_POLY_SET clearance_outline;
clearance_outline.Append( outline ); clearance_outline.Append( outline );
clearance_outline.Inflate( aDrawInfo.m_Mask_margin.x, segmentToCircleCount ); clearance_outline.Inflate( aDrawInfo.m_Mask_margin.x, segmentToCircleCount );
poly = &clearance_outline.Outline( 0 );
} }
else else
{ {