haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a few Coverity warnings.

This commit is contained in:
jean-pierre charras 2020-07-20 14:51:17 +02:00
parent 3b727b5d16
commit 6d8fb94d86
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
common/libeval_compiler/libeval_compiler.cpp
View File

@ -161,6 +161,9 @@ COMPILER::COMPILER()
m_parseFinished = false; m_parseFinished = false;
m_unitResolver.reset( new UNIT_RESOLVER ); m_unitResolver.reset( new UNIT_RESOLVER );
m_parser = LIBEVAL::ParseAlloc( malloc ); m_parser = LIBEVAL::ParseAlloc( malloc );
m_parseError = false;
m_parseErrorPos = 0;
m_tree = nullptr;
} }
@ -370,7 +373,7 @@ bool COMPILER::lexDefault( COMPILER::T_TOKEN& aToken )
break; break;
} }
libeval_dbg(10, "LEX ch '%c' pos %d\n", ch, m_tokenizer.GetPos() ); libeval_dbg(10, "LEX ch '%c' pos %lu\n", ch, (unsigned long)m_tokenizer.GetPos() );
if( ch == 0 ) if( ch == 0 )
{ {
@ -602,19 +605,20 @@ bool COMPILER::generateUCode( UCODE* aCode )
{ {
auto node = stack.back(); auto node = stack.back();
libeval_dbg( 4, "process node %p [op %d] [stack %d]\n", node, node->op, stack.size() ); libeval_dbg( 4, "process node %p [op %d] [stack %lu]\n",
node, node->op, (unsigned long)stack.size() );
// process terminal nodes first // process terminal nodes first
switch( node->op ) switch( node->op )
{ {
case TR_OP_FUNC_CALL: case TR_OP_FUNC_CALL:
break; break;
case TR_STRUCT_REF: case TR_STRUCT_REF:
{ {
assert( node->leaf[0]->op == TR_IDENTIFIER ); assert( node->leaf[0]->op == TR_IDENTIFIER );
//assert( node->leaf[1]->op == TR_IDENTIFIER ); //assert( node->leaf[1]->op == TR_IDENTIFIER );
switch( node->leaf[1]->op ) switch( node->leaf[1]->op )
{ {
case TR_IDENTIFIER: case TR_IDENTIFIER:
@ -658,8 +662,6 @@ bool COMPILER::generateUCode( UCODE* aCode )
break; break;
} }
} }
break; break;
} }
@ -682,12 +684,14 @@ bool COMPILER::generateUCode( UCODE* aCode )
break; break;
} }
case TR_STRING: case TR_STRING:
{ {
node->uop = makeUop( TR_UOP_PUSH_VALUE, node->value.str ); node->uop = makeUop( TR_UOP_PUSH_VALUE, node->value.str );
node->isTerminal = true; node->isTerminal = true;
break; break;
} }
default: default:
node->uop = makeUop( node->op ); node->uop = makeUop( node->op );
break; break;

1
qa/qa_utils/mocks.cpp
View File

@ -192,6 +192,7 @@ DIALOG_FIND_BASE::DIALOG_FIND_BASE( wxWindow* parent, wxWindowID id, const wxStr
m_findPrevious = nullptr; m_findPrevious = nullptr;
m_searchAgain = nullptr; m_searchAgain = nullptr;
m_closeButton = nullptr; m_closeButton = nullptr;
m_status = nullptr;
} }