Remove unused header

common/confirm.cpp

@@ -32,7 +32,6 @@
 #include <functional>
 #include <unordered_map>
 #include <pgm_base.h>
-#include "cli/cli_names.h"
 
 // Set of dialogs that have been chosen not to be shown again
 static std::unordered_map<unsigned long, int> doNotShowAgainDlgs;

common/pgm_base.cpp

@@ -45,7 +45,6 @@
 #include <advanced_config.h>
 #include <background_jobs_monitor.h>
 #include <bitmaps.h>
-#include <cli/cli_names.h> // Needed for the pre wx 3.2 cli workaround
 #include <common.h>
 #include <config_params.h>
 #include <confirm.h>

include/cli/cli_names.h

@@ -1,24 +0,0 @@
-/*
- * This program source code file is part of KiCad, a free EDA CAD application.
- *
- * Copyright (C) 1992-2022 KiCad Developers, see AUTHORS.txt for contributors.
- *
- * This program is free software: you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation, either version 3 of the License, or (at your
- * option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-#ifndef CLI_NAMES_H
-#define CLI_NAMES_H
-
-#define KICAD_CLI_APP_NAME wxT( "kicad_cli_app" )
-#endif

kicad/kicad_cli.cpp

@@ -74,7 +74,6 @@
 #include "cli/command_sym_upgrade.h"
 #include "cli/command_version.h"
 #include "cli/exit_codes.h"
-#include "cli/cli_names.h"
 
 // Add this header after all others, to avoid a collision name in a Windows header
 // on mingw.
@@ -284,10 +283,7 @@ static void printHelp( argparse::ArgumentParser& argParser )
 bool PGM_KICAD::OnPgmInit()
 {
     PGM_BASE::BuildArgvUtf8();
-    App().SetAppDisplayName( wxT( "KiCad-cli" ) );
-    // App name can be used by internal code to know if this is a
-    // kicad CLI app or a GUI app that is running
-    App().SetClassName( KICAD_CLI_APP_NAME );
+    App().SetAppDisplayName( wxT( "kicad-cli" ) );
 
 #if defined( DEBUG )
     wxString absoluteArgv0 = wxStandardPaths::Get().GetExecutablePath();