haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix not working Duplicate command in FP editor 

Fixes #16594
https://gitlab.com/kicad/code/kicad/-/issues/16594
This commit is contained in:
jean-pierre charras 2024-01-16 16:23:12 +01:00
parent 4c630e5aec
commit 76bd892f93
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pcbnew/tools/edit_tool.cpp
View File

@ -2,7 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application. * This program source code file is part of KiCad, a free EDA CAD application.
* *
* Copyright (C) 2013-2023 CERN * Copyright (C) 2013-2023 CERN
* Copyright (C) 2017-2023 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2017-2024 KiCad Developers, see AUTHORS.txt for contributors.
* @author Maciej Suminski <maciej.suminski@cern.ch> * @author Maciej Suminski <maciej.suminski@cern.ch>
* @author Tomasz Wlostowski <tomasz.wlostowski@cern.ch> * @author Tomasz Wlostowski <tomasz.wlostowski@cern.ch>
* *
@ -2445,6 +2445,15 @@ int EDIT_TOOL::Duplicate( const TOOL_EVENT& aEvent )
if( m_isFootprintEditor ) if( m_isFootprintEditor )
{ {
FOOTPRINT* parentFootprint = editFrame->GetBoard()->GetFirstFootprint(); FOOTPRINT* parentFootprint = editFrame->GetBoard()->GetFirstFootprint();
// PCB_FIELD items are specific items (not only graphic, but are properies )
// and cannot be duplicated like other footprint items. So skip it:
if( orig_item->Type() == PCB_FIELD_T )
{
orig_item->ClearSelected();
continue;
}
dupe_item = parentFootprint->DuplicateItem( orig_item ); dupe_item = parentFootprint->DuplicateItem( orig_item );
if( increment && dupe_item->Type() == PCB_PAD_T if( increment && dupe_item->Type() == PCB_PAD_T
@ -2456,6 +2465,10 @@ int EDIT_TOOL::Duplicate( const TOOL_EVENT& aEvent )
padTool->SetLastPadNumber( padNumber ); padTool->SetLastPadNumber( padNumber );
static_cast<PAD*>( dupe_item )->SetNumber( padNumber ); static_cast<PAD*>( dupe_item )->SetNumber( padNumber );
} }
dupe_item->ClearSelected();
new_items.push_back( dupe_item );
commit.Add( dupe_item );
} }
else if( /*FOOTPRINT* parentFootprint =*/ orig_item->GetParentFootprint() ) else if( /*FOOTPRINT* parentFootprint =*/ orig_item->GetParentFootprint() )
{ {