haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Symbol editor: clear the edit flags of a pasted pin after place it. 

When pasting a single pin, its edit flags were not cleared, and create
issues when trying to edit the pasted pin.
Fixes #14188
https://gitlab.com/kicad/code/kicad/issues/14188
This commit is contained in:
jean-pierre charras 2023-04-06 11:08:01 +02:00
parent 4d05bd62da
commit 7eb13c3d33
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
eeschema/lib_pin.cpp
View File

@ -1183,6 +1183,10 @@ void LIB_PIN::GetMsgPanelInfo( EDA_DRAW_FRAME* aFrame, std::vector<MSG_PANEL_ITE
aList.emplace_back( _( "Pos X" ), aFrame->MessageTextFromValue( pinpos.x, true ) );
aList.emplace_back( _( "Pos Y" ), aFrame->MessageTextFromValue( pinpos.y, true ) );
#if 0 // For debug purpose only
aList.emplace_back( _( "Flags" ), wxString::Format( "%8.8X", (long)GetFlags() ) );
#endif
}

7
eeschema/tools/symbol_editor_move_tool.cpp
View File

@ -317,8 +317,13 @@ int SYMBOL_EDITOR_MOVE_TOOL::Main( const TOOL_EVENT& aEvent )
try
{
if( !pinTool->PlacePin( (LIB_PIN*) selection.Front() ) )
LIB_PIN* curr_pin = (LIB_PIN*) selection.Front();
// PlacePin() will clear the current selection, so we need to reset
// flags of the selected pin here:
if( !pinTool->PlacePin( curr_pin ) )
restore_state = true;
else
curr_pin->ClearEditFlags();
}
catch( const boost::bad_pointer& e )
{