haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid double-caching FP zones 

Leads to crashes/invalid data when multi-threading hits both at same
time
This commit is contained in:
Seth Hillbrand 2022-07-05 19:28:46 -07:00
parent 7473528cf4
commit 7f9f37e507
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pcbnew/drc/drc_cache_generator.cpp
View File

@ -51,11 +51,11 @@ bool DRC_CACHE_GENERATOR::Run()
if( m_drcEngine->QueryWorstConstraint( PHYSICAL_HOLE_CLEARANCE_CONSTRAINT, worstConstraint ) )
m_largestPhysicalClearance = std::max( m_largestPhysicalClearance, worstConstraint.GetValue().Min() );
std::vector<ZONE*> allZones;
std::set<ZONE*> allZones;
for( ZONE* zone : m_board->Zones() )
{
allZones.push_back( zone );
allZones.insert( zone );
if( !zone->GetIsRuleArea() )
{
@ -76,7 +76,7 @@ bool DRC_CACHE_GENERATOR::Run()
for( ZONE* zone : footprint->Zones() )
{
allZones.push_back( zone );
allZones.insert( zone );
if( !zone->GetIsRuleArea() )
{
@ -152,12 +152,7 @@ bool DRC_CACHE_GENERATOR::Run()
m_drcEngine->SetMaxProgress( allZones.size() );
for( FOOTPRINT* footprint : m_board->Footprints() )
{
for( ZONE* zone : footprint->Zones() )
allZones.push_back( zone );
footprint->BuildPolyCourtyards();
}
thread_pool& tp = GetKiCadThreadPool();
std::vector<std::future<size_t>> returns;