haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Back out check-for-mouse-in-selection-bbox for PCBNew. 

Unlike eeschema, PCBNew has had a selection model for two major
releases so folks have gotten used to RMB acting on the selection
rather than what's under the mouse.

Plus it makes RMB after a drag-select nearly useless as your mouse
by definition ends up outside the selection bbox.

Fixes https://gitlab.com/kicad/code/kicad/issues/5857
This commit is contained in:
Jeff Young 2020-10-03 18:23:41 +01:00
parent 3144bab36f
commit 81154c9270
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pcbnew/tools/selection_tool.cpp
View File

@ -245,10 +245,8 @@ int SELECTION_TOOL::Main( const TOOL_EVENT& aEvent )
{ {
bool selectionCancelled = false; bool selectionCancelled = false;
if( m_selection.Empty() || if( m_selection.Empty() )
!m_selection.GetBoundingBox().Contains( wxPoint( evt->Position() ) ) )
{ {
ClearSelection();
selectPoint( evt->Position(), false, &selectionCancelled ); selectPoint( evt->Position(), false, &selectionCancelled );
m_selection.SetIsHover( true ); m_selection.SetIsHover( true );
} }