haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle blind/buried vias in Eagle import 

Don't sanitize layers before setting type

Fixes https://gitlab.com/kicad/code/kicad/issues/9557
This commit is contained in:
Seth Hillbrand 2021-11-08 12:46:18 -08:00
parent 24002b1eca
commit 81fc7c71d1
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pcbnew/plugins/eagle/eagle_plugin.cpp
View File

@ -2625,18 +2625,20 @@ void EAGLE_PLUGIN::loadSignals( wxXmlNode* aSignals )
m_xpath->push( "via" ); m_xpath->push( "via" );
EVIA v( netItem ); EVIA v( netItem );
if( v.layer_front_most > v.layer_back_most )
std::swap( v.layer_front_most, v.layer_back_most );
PCB_LAYER_ID layer_front_most = kicad_layer( v.layer_front_most ); PCB_LAYER_ID layer_front_most = kicad_layer( v.layer_front_most );
PCB_LAYER_ID layer_back_most = kicad_layer( v.layer_back_most ); PCB_LAYER_ID layer_back_most = kicad_layer( v.layer_back_most );
if( IsCopperLayer( layer_front_most ) && IsCopperLayer( layer_back_most ) ) if( IsCopperLayer( layer_front_most ) && IsCopperLayer( layer_back_most )
&& layer_front_most != layer_back_most )
{ {
int kidiam; int kidiam;
int drillz = v.drill.ToPcbUnits(); int drillz = v.drill.ToPcbUnits();
PCB_VIA* via = new PCB_VIA( m_board ); PCB_VIA* via = new PCB_VIA( m_board );
m_board->Add( via ); m_board->Add( via );
via->SetLayerPair( layer_front_most, layer_back_most );
if( v.diam ) if( v.diam )
{ {
kidiam = v.diam->ToPcbUnits(); kidiam = v.diam->ToPcbUnits();
@ -2680,14 +2682,24 @@ void EAGLE_PLUGIN::loadSignals( wxXmlNode* aSignals )
m_min_annulus = ( kidiam - drillz ) / 2; m_min_annulus = ( kidiam - drillz ) / 2;
if( layer_front_most == F_Cu && layer_back_most == B_Cu ) if( layer_front_most == F_Cu && layer_back_most == B_Cu )
{
via->SetViaType( VIATYPE::THROUGH ); via->SetViaType( VIATYPE::THROUGH );
else if( layer_front_most == F_Cu || layer_back_most == B_Cu ) }
/// This is, at best, a guess. Eagle doesn't seem to differentiate
/// between blind/buried vias that only go one layer and micro vias
/// so the user will need to clean up a bit
else if( v.layer_back_most - v.layer_front_most == 1 )
{
via->SetViaType( VIATYPE::MICROVIA ); via->SetViaType( VIATYPE::MICROVIA );
}
else else
{
via->SetViaType( VIATYPE::BLIND_BURIED ); via->SetViaType( VIATYPE::BLIND_BURIED );
}
wxPoint pos( kicad_x( v.x ), kicad_y( v.y ) ); wxPoint pos( kicad_x( v.x ), kicad_y( v.y ) );
via->SetLayerPair( layer_front_most, layer_back_most );
via->SetPosition( pos ); via->SetPosition( pos );
via->SetEnd( pos ); via->SetEnd( pos );