haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

STEP export: don't fail when can't construct a wire. 

This can happen with very small shapes.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17774


(cherry picked from commit 481c1592ae)

Co-authored-by: Alex Shvartzkop <dudesuchamazing@gmail.com>
This commit is contained in:
dsa-t 2024-04-16 22:36:34 +00:00
parent 374fb0f5f2
commit 822409225a
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pcbnew/exporters/step/step_pcb_model.cpp
View File

@ -851,18 +851,32 @@ bool STEP_PCB_MODEL::MakeShapes( std::vector<TopoDS_Shape>& aShapes, const SHAPE
if( !makeWireFromChain( mkWire, contour ) )
continue;
wxASSERT( mkWire.IsDone() );
if( !mkWire.IsDone() )
{
ReportMessage( wxString::Format(
_( "Wire not done (contour %d, points %d): OCC error %d\n" ),
static_cast<int>( contId ), static_cast<int>( contour.PointCount() ),
static_cast<int>( mkWire.Error() ) ) );
}
if( contId == 0 ) // Outline
mkFace = BRepBuilderAPI_MakeFace( mkWire.Wire() );
{
if( mkWire.IsDone() )
mkFace = BRepBuilderAPI_MakeFace( mkWire.Wire() );
else
continue;
}
else // Hole
mkFace.Add( mkWire );
{
if( mkWire.IsDone() )
mkFace.Add( mkWire );
}
}
catch( const Standard_Failure& e )
{
ReportMessage(
wxString::Format( wxT( "MakeShapes (contour %d): OCC exception: %s\n" ),
contId, e.GetMessageString() ) );
static_cast<int>( contId ), e.GetMessageString() ) );
return false;
}
}