haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

performance efficiencies

This commit is contained in:
Jeff Young 2023-12-18 17:39:29 +00:00
parent 68cbb820a7
commit 8251fca66a
11 changed files with 28 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/dialogs/panel_setup_netclasses.cpp
View File

@ -76,7 +76,7 @@ PANEL_SETUP_NETCLASSES::PANEL_SETUP_NETCLASSES( wxWindow* aParentWindow, EDA_DRA
PANEL_SETUP_NETCLASSES_BASE( aParentWindow ),
m_frame( aFrame ),
m_isEEschema( aIsEEschema ),
m_netSettings( aNetSettings ),
m_netSettings( std::move( aNetSettings ) ),
m_netNames( aNetNames ),
m_lastCheckedTicker( 0 ),
m_hoveredCol( -1 ),
@ -788,7 +788,7 @@ void PANEL_SETUP_NETCLASSES::ImportSettingsFrom( const std::shared_ptr<NET_SETTI
m_netclassGrid->ForceRefresh();
m_assignmentGrid->ForceRefresh();
m_netSettings = savedSettings;
m_netSettings = std::move( savedSettings );
}

2
common/dialogs/panel_setup_severities.cpp
View File

@ -37,7 +37,7 @@ PANEL_SETUP_SEVERITIES::PANEL_SETUP_SEVERITIES( wxWindow* aParentWindow,
RC_ITEM* aPinMapSpecialCase ) :
wxPanel( aParentWindow ),
m_severities( aSeverities ),
m_items( aItems ),
m_items( std::move( aItems ) ),
m_pinMapSpecialCase( aPinMapSpecialCase )
{
wxString severities[] = { _( "Error" ), _( "Warning" ), _( "Ignore" ) };

4
common/properties/property_mgr.cpp
View File

@ -202,7 +202,7 @@ void PROPERTY_MANAGER::OverrideAvailability( TYPE_ID aDerived, TYPE_ID aBase,
wxASSERT_MSG( aDerived != aBase, "Class cannot override from itself" );
CLASS_DESC& derived = getClass( aDerived );
derived.m_availabilityOverrides[std::make_pair( aBase, aName )] = aFunc;
derived.m_availabilityOverrides[std::make_pair( aBase, aName )] = std::move( aFunc );
m_dirty = true;
}
@ -214,7 +214,7 @@ void PROPERTY_MANAGER::OverrideWriteability( TYPE_ID aDerived, TYPE_ID aBase,
wxASSERT_MSG( aDerived != aBase, "Class cannot override from itself" );
CLASS_DESC& derived = getClass( aDerived );
derived.m_writeabilityOverrides[std::make_pair( aBase, aName )] = aFunc;
derived.m_writeabilityOverrides[std::make_pair( aBase, aName )] = std::move( aFunc );
m_dirty = true;
}

4
include/properties/property.h
View File

@ -248,7 +248,7 @@ PROPERTY_BASE( const wxString& aName, PROPERTY_DISPLAY aDisplay = PT_DEFAULT,
*/
PROPERTY_BASE& SetAvailableFunc( std::function<bool(INSPECTABLE*)> aFunc )
{
m_availFunc = aFunc;
m_availFunc = std::move( aFunc );
return *this;
}
@ -259,7 +259,7 @@ PROPERTY_BASE( const wxString& aName, PROPERTY_DISPLAY aDisplay = PT_DEFAULT,
PROPERTY_BASE& SetWriteableFunc( std::function<bool(INSPECTABLE*)> aFunc )
{
m_writeableFunc = aFunc;
m_writeableFunc = std::move( aFunc );
return *this;
}

2
include/settings/json_settings_internals.h
View File

@ -44,7 +44,7 @@ public:
void SetFromString( const std::string& aPath, ValueType aVal )
{
// Calls the overload below, which will convert from dotted string to JSON pointer
( *this )[aPath] = aVal;
( *this )[aPath] = std::move( aVal );
}
template<typename ValueType>

2
libs/kimath/src/geometry/shape_poly_set.cpp
View File

@ -946,7 +946,7 @@ void SHAPE_POLY_SET::booleanOp( Clipper2Lib::ClipType aType, const SHAPE_POLY_SE
//@todo amend X,Y values to true intersection between arcs or arc and segment
};
c.SetZCallback( callback ); // register callback
c.SetZCallback( std::move( callback ) ); // register callback
c.Execute( aType, Clipper2Lib::FillRule::NonZero, solution );

2
pcbnew/board_stackup_manager/panel_board_finish.cpp
View File

@ -102,7 +102,7 @@ bool PANEL_SETUP_BOARD_FINISH::TransferDataFromWindow()
void PANEL_SETUP_BOARD_FINISH::ImportSettingsFrom( BOARD* aBoard )
{
BOARD* savedBrd = m_board;
BOARD* savedBrd = m_board;
BOARD_DESIGN_SETTINGS* savedSettings = m_brdSettings;
m_brdSettings = &aBoard->GetDesignSettings();

6
pcbnew/dialogs/panel_setup_tuning_patterns.cpp
View File

@ -123,7 +123,7 @@ void PANEL_SETUP_TUNING_PATTERNS::ImportSettingsFrom( BOARD* aBoard )
m_skewSettings = aBoard->GetDesignSettings().m_skewMeanderSettings;
TransferDataToWindow();
m_trackSettings = savedTrackSettings;
m_dpSettings = savedDPSettings;
m_skewSettings = savedSkewSettings;
m_trackSettings = std::move( savedTrackSettings );
m_dpSettings = std::move( savedDPSettings );
m_skewSettings = std::move( savedSkewSettings );
}

14
pcbnew/drc/drc_report.cpp
View File

@ -30,15 +30,15 @@
#include <rc_json_schema.h>
DRC_REPORT::DRC_REPORT(BOARD* aBoard, EDA_UNITS aReportUnits,
std::shared_ptr<RC_ITEMS_PROVIDER> aMarkersProvider,
std::shared_ptr<RC_ITEMS_PROVIDER> aRatsnestProvider,
std::shared_ptr<RC_ITEMS_PROVIDER> aFpWarningsProvider) :
DRC_REPORT::DRC_REPORT( BOARD* aBoard, EDA_UNITS aReportUnits,
std::shared_ptr<RC_ITEMS_PROVIDER> aMarkersProvider,
std::shared_ptr<RC_ITEMS_PROVIDER> aRatsnestProvider,
std::shared_ptr<RC_ITEMS_PROVIDER> aFpWarningsProvider) :
m_board( aBoard ),
m_reportUnits( aReportUnits ),
m_markersProvider( aMarkersProvider ),
m_ratsnestProvider( aRatsnestProvider ),
m_fpWarningsProvider( aFpWarningsProvider )
m_markersProvider( std::move( aMarkersProvider ) ),
m_ratsnestProvider( std::move( aRatsnestProvider ) ),
m_fpWarningsProvider( std::move( aFpWarningsProvider ) )
{
}

2
pcbnew/tools/board_inspection_tool.cpp
View File

@ -1770,7 +1770,7 @@ int BOARD_INSPECTION_TOOL::HighlightNet( const TOOL_EVENT& aEvent )
settings->SetHighlight( m_lastHighlighted );
m_toolMgr->GetView()->UpdateAllLayersColor();
m_currentlyHighlighted = m_lastHighlighted;
m_lastHighlighted = temp;
m_lastHighlighted = std::move( temp );
}
else if( aEvent.IsAction( &PCB_ACTIONS::toggleNetHighlight ) )
{

10
pcbnew/tools/item_modification_routine.h
View File

@ -117,8 +117,9 @@ public:
CALLABLE_BASED_HANDLER( CREATION_HANDLER aCreationHandler,
MODIFICATION_HANDLER aModificationHandler,
DELETION_HANDLER aDeletionHandler ) :
m_creationHandler( aCreationHandler ),
m_modificationHandler( aModificationHandler ), m_deletionHandler( aDeletionHandler )
m_creationHandler( std::move( aCreationHandler ) ),
m_modificationHandler( std::move( aModificationHandler ) ),
m_deletionHandler( std::move( aDeletionHandler ) )
{
}
@ -152,7 +153,10 @@ public:
};
ITEM_MODIFICATION_ROUTINE( BOARD_ITEM* aBoard, CHANGE_HANDLER& aHandler ) :
m_board( aBoard ), m_handler( aHandler ), m_numSuccesses( 0 ), m_numFailures( 0 )
m_board( aBoard ),
m_handler( aHandler ),
m_numSuccesses( 0 ),
m_numFailures( 0 )
{
}