haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent dereferencing end iterator

This commit is contained in:
Seth Hillbrand 2023-07-25 10:49:13 -07:00
parent 589030d672
commit 8546d417df
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/core/version_compare.cpp
View File

@ -25,13 +25,13 @@ const std::vector<int> parseVersionString( const std::string& versionString )
std::vector<int> versionComponents; std::vector<int> versionComponents;
auto it = versionString.begin(); auto it = versionString.begin();
auto end = versionString.end(); auto end = versionString.end();
const char* end_char = versionString.data() + versionString.size();
while( it != end ) while( it != end )
{ {
versionComponents.emplace_back( 0 ); versionComponents.emplace_back( 0 );
// On error, the last element will be 0 // On error, the last element will be 0
auto result = std::from_chars( &( *it ), &( *end ), versionComponents.back() ); auto result = std::from_chars( &( *it ), end_char, versionComponents.back() );
it += std::distance( &( *it ), result.ptr ); // Update the iterator it += std::distance( &( *it ), result.ptr ); // Update the iterator
if( it != end && *it == '.' ) if( it != end && *it == '.' )