haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

footprint selector in symbol properties: fix footprint selection issue. 

When using the button to select a footprint using the footprint chooser
dialog, the new footprint was not always taken in account (perhaps MSW specific).
It was due to the code to update the footprint name was between Disable() and
Enable, thus creating a loss of some events in the complex grid edition stuff.
This is now replaced by a lock flag to protect this code to be executed when
it should not.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/18270
This commit is contained in:
jean-pierre charras 2024-06-27 19:54:24 +02:00
parent 64c36e8bda
commit 8737c6eb3c
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
common/widgets/grid_text_button_helpers.cpp
View File

@ -2,7 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application. * This program source code file is part of KiCad, a free EDA CAD application.
* *
* Copyright (C) 2021 CERN * Copyright (C) 2021 CERN
* Copyright (C) 2018-2023 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2018-2024 KiCad Developers, see AUTHORS.txt for contributors.
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -239,6 +239,7 @@ public:
m_preselect( aPreselect ), m_preselect( aPreselect ),
m_symbolNetlist( aSymbolNetlist.ToStdString() ) m_symbolNetlist( aSymbolNetlist.ToStdString() )
{ {
m_buttonFpChooserLock = false;
SetButtonBitmaps( KiBitmapBundle( BITMAPS::small_library ) ); SetButtonBitmaps( KiBitmapBundle( BITMAPS::small_library ) );
// win32 fix, avoids drawing the "native dropdown caret" // win32 fix, avoids drawing the "native dropdown caret"
@ -253,17 +254,21 @@ protected:
void OnButtonClick() override void OnButtonClick() override
{ {
if( m_buttonFpChooserLock ) // The button to show the FP chooser is clicked, but
// a previous click is currently in progress.
return;
// Disable the button until we have finished processing it. Normally this is not an issue
// but if the footprint chooser is loading for the first time, it can be slow enough that
// multiple clicks will cause multiple instances of the footprint loader process to start
m_buttonFpChooserLock = true;
// pick a footprint using the footprint picker. // pick a footprint using the footprint picker.
wxString fpid = GetValue(); wxString fpid = GetValue();
if( fpid.IsEmpty() ) if( fpid.IsEmpty() )
fpid = m_preselect; fpid = m_preselect;
// Disable the button until we have finished processing it. Normally this is not an issue
// but if the footprint chooser is loading for the first time, it can be slow enough that
// multiple clicks will cause multiple instances of the footprint loader process to start
Disable();
if( KIWAY_PLAYER* frame = m_dlg->Kiway().Player( FRAME_FOOTPRINT_CHOOSER, true, m_dlg ) ) if( KIWAY_PLAYER* frame = m_dlg->Kiway().Player( FRAME_FOOTPRINT_CHOOSER, true, m_dlg ) )
{ {
if( !m_symbolNetlist.empty() ) if( !m_symbolNetlist.empty() )
@ -278,13 +283,16 @@ protected:
frame->Destroy(); frame->Destroy();
} }
Enable(); m_buttonFpChooserLock = false;
} }
protected: protected:
DIALOG_SHIM* m_dlg; DIALOG_SHIM* m_dlg;
wxString m_preselect; wxString m_preselect;
// Lock flag to lock the button to show the FP chooser
// true when the button is busy, waiting all footprints loaded to
// avoid running more than once the FP chooser
bool m_buttonFpChooserLock;
/* /*
* Symbol netlist format: * Symbol netlist format:
* pinNumber pinName <tab> pinNumber pinName... * pinNumber pinName <tab> pinNumber pinName...