haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Huge performance win for Preferences. 

The Hotkey list was recalculating the widths of all columns on
every single cell addition.
This commit is contained in:
Jeff Young 2020-12-05 01:10:28 +00:00
parent a3406e7514
commit 8781ce7efb
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
common/widgets/widget_hotkey_list.cpp
View File

@ -30,7 +30,7 @@
#include <wx/menu.h> #include <wx/menu.h>
#include <tool/tool_action.h> #include <tool/tool_action.h>
#include <dialog_shim.h> #include <dialog_shim.h>
#include <wx/dcclient.h>
/** /**
* Menu IDs for the hotkey context menu * Menu IDs for the hotkey context menu
@ -451,12 +451,9 @@ WIDGET_HOTKEY_LIST::WIDGET_HOTKEY_LIST( wxWindow* aParent, HOTKEY_STORE& aHotkey
if( !m_readOnly ) if( !m_readOnly )
command_header << " " << _( "(double-click to edit)" ); command_header << " " << _( "(double-click to edit)" );
AppendColumn( command_header, wxCOL_WIDTH_AUTOSIZE, wxALIGN_LEFT, AppendColumn( command_header, 450, wxALIGN_LEFT, wxCOL_RESIZABLE | wxCOL_SORTABLE );
wxCOL_RESIZABLE | wxCOL_SORTABLE ); AppendColumn( _( "Hotkey" ), 120, wxALIGN_LEFT, wxCOL_RESIZABLE | wxCOL_SORTABLE );
AppendColumn( _( "Hotkey" ), wxCOL_WIDTH_AUTOSIZE, wxALIGN_LEFT, AppendColumn( _( "Description" ), 900, wxALIGN_LEFT, wxCOL_RESIZABLE | wxCOL_SORTABLE );
wxCOL_RESIZABLE | wxCOL_SORTABLE );
AppendColumn( _( "Description" ), wxCOL_WIDTH_AUTOSIZE, wxALIGN_LEFT,
wxCOL_RESIZABLE | wxCOL_SORTABLE );
GetDataView()->SetIndent( 10 ); GetDataView()->SetIndent( 10 );
if( !m_readOnly ) if( !m_readOnly )
@ -488,6 +485,9 @@ void WIDGET_HOTKEY_LIST::ResetAllHotkeys( bool aResetToDefault )
m_hk_store.ResetAllHotkeysToOriginal(); m_hk_store.ResetAllHotkeysToOriginal();
UpdateFromClientData(); UpdateFromClientData();
GetDataView()->GetColumn( 0 )->SetWidth( wxCOL_WIDTH_AUTOSIZE );
GetDataView()->GetColumn( 1 )->SetWidth( wxCOL_WIDTH_AUTOSIZE );
Thaw(); Thaw();
} }
@ -524,6 +524,9 @@ void WIDGET_HOTKEY_LIST::updateShownItems( const wxString& aFilterStr )
} }
UpdateFromClientData(); UpdateFromClientData();
GetDataView()->GetColumn( 0 )->SetWidth( wxCOL_WIDTH_AUTOSIZE );
GetDataView()->GetColumn( 1 )->SetWidth( wxCOL_WIDTH_AUTOSIZE );
Thaw(); Thaw();
} }